Skip to content

benchmark,test: remove output from readable-async-iterator benchmark - #34411

Closed
Trott wants to merge 0 commit into
nodejs:masterfrom
Trott:fix-benchmark-test
Closed

benchmark,test: remove output from readable-async-iterator benchmark#34411
Trott wants to merge 0 commit into
nodejs:masterfrom
Trott:fix-benchmark-test

Conversation

@Trott

@TrottTrott commented Jul 17, 2020

Copy link
Copy Markdown
Member

Extra output makes test-benchmark-streams fail. Change console.log() to
console.assert().

Fixes: #34409

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added benchmark Issues and PRs related to the benchmark subsystem. stream Issues and PRs related to the stream subsystem. labels Jul 17, 2020
@TrottTrott mentioned this pull request Jul 17, 2020
Closed
@Trott

Trott commented Jul 17, 2020

Copy link
Copy Markdown
MemberAuthor

cc @ronag@richardlau

@Trott

Trott commented Jul 17, 2020

Copy link
Copy Markdown
MemberAuthor

Would like to fast-track to unbreak CI. Collaborators, please 👍 here to fast-track.

@Trott
Trott requested a review from ronagJuly 17, 2020 13:04
@TrottTrott added fast-track PRs that do not need to wait for 48 hours to land. flaky-test Issues and PRs related to the tests with unstable failures on the CI. labels Jul 17, 2020
@ronag

ronag commented Jul 17, 2020

Copy link
Copy Markdown
Member

Did I make a mistake somewhere when landing #34035? Shouldn't I have seen this in CI?

@Trott

Trott commented Jul 17, 2020•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Did I make a mistake somewhere when landing #34035? Shouldn't I have seen this in CI?

The last CI on the relevant PR was two weeks ago, but we only re-added benchmark tests to CI in the last day or two. You did everything the way you were supposed to. @mmarchini is working on a commit queue and if that works out, it should prevent stuff like this in the future.

@nodejs-github-bot

nodejs-github-bot commented Jul 17, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32383/

@TrottTrott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 17, 2020
Trott added a commit that referenced this pull request Jul 17, 2020
@Trott
benchmark,test: remove output from readable-async-iterator benchmark
d10c59f
Extra output makes test-benchmark-streams fail. Change console.log() to
console.assert().
Fixes: #34409
PR-URL: #34411
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
@TrottTrott closed this Jul 17, 2020
@Trott
Trottforce-pushed the fix-benchmark-test branch from 7a7aa9b to d10c59fCompareJuly 17, 2020 15:41
@Trott

Trott commented Jul 17, 2020

Copy link
Copy Markdown
MemberAuthor

Landed in d10c59f

@Trott
Trott deleted the fix-benchmark-test branch July 17, 2020 15:42
@ruyadorno

ruyadorno commented Jul 22, 2020

Copy link
Copy Markdown
Member

Adding dont-land labels since this builds on top of a semver-major change

cjihrig pushed a commit that referenced this pull request Jul 23, 2020
@Trott@cjihrig
benchmark,test: remove output from readable-async-iterator benchmark
70823ef
Extra output makes test-benchmark-streams fail. Change console.log() to
console.assert().
Fixes: #34409
PR-URL: #34411
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ronagronagronag approved these changes
@richardlaurichardlaurichardlau approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.benchmarkIssues and PRs related to the benchmark subsystem.fast-trackPRs that do not need to wait for 48 hours to land.flaky-testIssues and PRs related to the tests with unstable failures on the CI.streamIssues and PRs related to the stream subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

benchmark/test-benchmark-streams failed

5 participants

@Trott@ronag@nodejs-github-bot@ruyadorno@richardlau