Skip to content

src: guard against nullptr deref in TimerWrapHandle::Stop - #34460

Closed
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:timer-wrap-nullptr-deref
Closed

src: guard against nullptr deref in TimerWrapHandle::Stop#34460
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:timer-wrap-nullptr-deref

Conversation

@addaleax

@addaleaxaddaleax commented Jul 21, 2020

Copy link
Copy Markdown
Member

Refs: #34454

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. labels Jul 21, 2020
@addaleaxaddaleax mentioned this pull request Jul 21, 2020
Closed
4 tasks
@nodejs-github-bot

nodejs-github-bot commented Jul 21, 2020•
edited by addaleax
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32442/ (:green_heart:)

@jasnelljasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 21, 2020
@jasnell

jasnell commented Jul 21, 2020

Copy link
Copy Markdown
Member

Fast-track? Please 👍🏻

@addaleaxaddaleax added the fast-track PRs that do not need to wait for 48 hours to land. label Jul 21, 2020
@addaleax

addaleax commented Jul 21, 2020

Copy link
Copy Markdown
MemberAuthor

Landed in feb93c4

addaleax added a commit that referenced this pull request Jul 21, 2020
@addaleax
src: guard against nullptr deref in TimerWrapHandle::Stop
feb93c4
Refs: #34454
PR-URL: #34460
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
@addaleax
addaleax deleted the timer-wrap-nullptr-deref branch July 21, 2020 19:11
cjihrig pushed a commit that referenced this pull request Jul 23, 2020
@addaleax@cjihrig
src: guard against nullptr deref in TimerWrapHandle::Stop
fe69e1e
Refs: #34454
PR-URL: #34460
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
@ruyadorno

ruyadorno commented Jul 28, 2020

Copy link
Copy Markdown
Member

This does not land cleanly on v14.x 🤔 should it be backported ?

@targostargos removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backport-requested-v14.x labels Apr 30, 2021
targos pushed a commit that referenced this pull request May 1, 2021
@addaleax@targos
src: guard against nullptr deref in TimerWrapHandle::Stop
b1d5160
Refs: #34454
PR-URL: #34460
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
@danielleadamsdanielleadams mentioned this pull request May 3, 2021
Merged
This was referenced May 22, 2023
Open
Open
Open
@137717unity137717unity mentioned this pull request May 22, 2023
Open
@snyk-botsnyk-bot mentioned this pull request May 23, 2023
Open
@wedataintelligencewedataintelligence mentioned this pull request May 24, 2023
Open
@baby636baby636 mentioned this pull request May 24, 2023
Open
@aliceUnhinged613aliceUnhinged613 mentioned this pull request Nov 25, 2023
Open
@wedataintelligencewedataintelligence mentioned this pull request Nov 28, 2023
Open
@baby636baby636 mentioned this pull request Nov 28, 2023
Open
@ron-a20ron-a20 mentioned this pull request Dec 19, 2023
Open
@137717unity137717unity mentioned this pull request Dec 19, 2023
Open
@wedataintelligencewedataintelligence mentioned this pull request Dec 19, 2023
Open
@aliceUnhinged613aliceUnhinged613 mentioned this pull request Dec 19, 2023
Open
@baby636baby636 mentioned this pull request Dec 20, 2023
Open
@137717unity137717unity mentioned this pull request Apr 14, 2024
Open
@aliceUnhinged613aliceUnhinged613 mentioned this pull request Apr 14, 2024
Open
@ron-a20ron-a20 mentioned this pull request Apr 14, 2024
Open
@molllyn1molllyn1 mentioned this pull request Apr 14, 2024
Open
@kissofirekissofire mentioned this pull request Apr 14, 2024
Open
@wedataintelligencewedataintelligence mentioned this pull request Apr 14, 2024
Open
@baby636baby636 mentioned this pull request Apr 15, 2024
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@gengjiawengengjiawengengjiawen approved these changes
@richardlaurichardlaurichardlau approved these changes
+1 more reviewer
@devnexendevnexendevnexen approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++Issues and PRs that require attention from people who are familiar with C++.fast-trackPRs that do not need to wait for 48 hours to land.timersIssues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@addaleax@nodejs-github-bot@jasnell@ruyadorno@gengjiawen@devnexen@richardlau@targos