Skip to content

Revert "src: simplify format in node_file.cc" - #34463

Closed
MylesBorins wants to merge 1 commit into
nodejs:masterfrom
MylesBorins:revert-33660
Closed

Revert "src: simplify format in node_file.cc"#34463
MylesBorins wants to merge 1 commit into
nodejs:masterfrom
MylesBorins:revert-33660

Conversation

@MylesBorins

@MylesBorinsMylesBorins commented Jul 21, 2020

Copy link
Copy Markdown
Contributor

This reverts commit 673f49a.

This change is breaking gulp on v14.x. Reverting so we can reland in a
way that doesn't break stuff

Refs: #33660
Refs: #34371

@MylesBorins
Revert "src: simplify format in node_file.cc"
4761579
This reverts commit 673f49a.
This change is breaking gulp on v14.x. Reverting so we can reland in a
way that doesn't break stuff
Refs: nodejs#33660
Refs: nodejs#34371
@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. labels Jul 21, 2020
@MylesBorins

MylesBorins commented Jul 21, 2020

Copy link
Copy Markdown
ContributorAuthor

@himself65 FYI

@MylesBorins

MylesBorins commented Jul 21, 2020

Copy link
Copy Markdown
ContributorAuthor

Can we please fast track so we can get this in 14.6.0

@MylesBorinsMylesBorins added the fast-track PRs that do not need to wait for 48 hours to land. label Jul 21, 2020
@nodejs-github-bot

nodejs-github-bot commented Jul 21, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32443/

@addaleax

addaleax commented Jul 21, 2020

Copy link
Copy Markdown
Member

… this is very surprising – it’s purely a formatting change. If this breaks gulp, then gulp is already broken, but it seems almost impossible that this change actually affects behavior in anyway.

If you are certain that this is breaking, maybe just leave the commit out of the v14.6.0 proposal?

@MylesBorins

MylesBorins commented Jul 21, 2020

Copy link
Copy Markdown
ContributorAuthor

@addaleax this change went out in v14.5.0 and broke the gulp test suite. Reverting this change in v14.6.0 fixes it.

I'll admit that I am also surprised that this change is having that effect. Although honestly I just ran the test suite again and this revert was not fixing it... TBH I'm very confused right now and will dig in a bit more

@addaleax

addaleax commented Jul 21, 2020

Copy link
Copy Markdown
Member

@MylesBorins Maybe some other change made the test suite flaky? I think that seems like a more likely cause…

@MylesBorins

MylesBorins commented Jul 21, 2020

Copy link
Copy Markdown
ContributorAuthor

there is definitely a change on 14.5.0 that broke gulp, perhaps this was a false positive from bisect

Running bisect again and a few more manual tests... since when I checked again this revert didn't actually fix the problem I was seeing

@MylesBorins

MylesBorins commented Jul 21, 2020

Copy link
Copy Markdown
ContributorAuthor

Closing as manual testing again on local machine shows gulp still failing

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@himself65himself65Awaiting requested review from himself65

Assignees

No one assigned

Labels

c++Issues and PRs that require attention from people who are familiar with C++.fast-trackPRs that do not need to wait for 48 hours to land.fsIssues and PRs related to the fs subsystem / file system.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MylesBorins@nodejs-github-bot@addaleax