Skip to content

test: fix test-heapdump-zlib - #34499

Closed
puzpuzpuz wants to merge 2 commits into
nodejs:masterfrom
puzpuzpuz:fix/broken-pummel-test-for-zlib
Closed

test: fix test-heapdump-zlib#34499
puzpuzpuz wants to merge 2 commits into
nodejs:masterfrom
puzpuzpuz:fix/broken-pummel-test-for-zlib

Conversation

@puzpuzpuz

@puzpuzpuzpuzpuzpuz commented Jul 23, 2020

Copy link
Copy Markdown
Member

Refs: #34048

Fixes test/pummel/test-heapdump-zlib.js which was broken by #34048.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@puzpuzpuzpuzpuzpuz added zlib Issues and PRs related to the zlib subsystem. test Issues and PRs related to the tests. labels Jul 23, 2020
@puzpuzpuz
puzpuzpuzforce-pushed the fix/broken-pummel-test-for-zlib branch from 50910cb to 42a4793CompareJuly 23, 2020 20:29
@puzpuzpuzpuzpuzpuz mentioned this pull request Jul 23, 2020
Closed
4 tasks
@puzpuzpuz
puzpuzpuzforce-pushed the fix/broken-pummel-test-for-zlib branch from 42a4793 to 6b6841cCompareJuly 23, 2020 20:32
@puzpuzpuzpuzpuzpuz changed the title test: fix pummel zlib testtest: fix test-heapdump-zlibJul 23, 2020
richardlau
richardlau reviewed Jul 23, 2020
View reviewed changes
Comment threadtest/pummel/test-heapdump-zlib.js Outdated
@puzpuzpuz
puzpuzpuzforce-pushed the fix/broken-pummel-test-for-zlib branch from 6b6841c to 35d87dcCompareJuly 23, 2020 20:38
@puzpuzpuz
puzpuzpuzforce-pushed the fix/broken-pummel-test-for-zlib branch from 35d87dc to e2fef24CompareJuly 23, 2020 20:40
@richardlau

richardlau commented Jul 23, 2020

Copy link
Copy Markdown
Member

I've requested a pummel CI run (queued): https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/15556/

@nodejs-github-bot

This comment has been minimized.

Sign in to view
@richardlau

richardlau commented Jul 23, 2020

Copy link
Copy Markdown
Member

If the CI's come back green I'd suggest fast tracking to unbreak the daily builds.

@addaleaxaddaleax added the fast-track PRs that do not need to wait for 48 hours to land. label Jul 23, 2020
Trott
Trott reviewed Jul 23, 2020
View reviewed changes
Comment threadtest/pummel/test-heapdump-zlib.js Outdated
@Trott

Trott commented Jul 23, 2020•
edited
Loading

Copy link
Copy Markdown
Member

Pummel CI re-run: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/15561/ ✅

@nodejs-github-bot

nodejs-github-bot commented Jul 23, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32496/

@nodejs-github-bot

nodejs-github-bot commented Jul 24, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32497/

@github-actionsgithub-actionsBot mentioned this pull request Jul 24, 2020
Open
6 tasks
@nodejs-github-bot

nodejs-github-bot commented Jul 24, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32498/

@nodejs-github-bot

nodejs-github-bot commented Jul 24, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32499/

@nodejs-github-bot

nodejs-github-bot commented Jul 24, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32502/

Trott pushed a commit that referenced this pull request Jul 24, 2020
@puzpuzpuz@Trott
test: fix test-heapdump-zlib
d1e4e8e
PR-URL: #34499
Refs: #34048
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Trott

Trott commented Jul 24, 2020

Copy link
Copy Markdown
Member

Landed in d1e4e8e

Thanks for the quick fix!

@TrottTrott closed this Jul 24, 2020
@puzpuzpuz
puzpuzpuz deleted the fix/broken-pummel-test-for-zlib branch July 24, 2020 06:58
This was referenced Jul 25, 2020
Open
Open
Open
MylesBorins pushed a commit that referenced this pull request Jul 27, 2020
@puzpuzpuz@MylesBorins
test: fix test-heapdump-zlib
3f11ba1
PR-URL: #34499
Refs: #34048
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@github-actionsgithub-actionsBot mentioned this pull request Jul 28, 2020
Open
3 tasks
@ruyadornoruyadorno mentioned this pull request Jul 28, 2020
Merged
This was referenced Jul 29, 2020
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@puzpuzpuz@addaleax
test: fix test-heapdump-zlib
aa576eb
PR-URL: #34499
Refs: #34048
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@puzpuzpuz@addaleax
test: fix test-heapdump-zlib
afd6e46
PR-URL: #34499
Refs: #34048
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@codebyterecodebytere mentioned this pull request Sep 28, 2020
Merged
@mhdawsonmhdawson mentioned this pull request Jan 18, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrottTrottTrott approved these changes
@addaleaxaddaleaxaddaleax approved these changes
@richardlaurichardlaurichardlau approved these changes

Assignees

No one assigned

Labels

fast-trackPRs that do not need to wait for 48 hours to land.testIssues and PRs related to the tests.zlibIssues and PRs related to the zlib subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@puzpuzpuz@richardlau@nodejs-github-bot@Trott@addaleax