Uh oh!
There was an error while loading. Please reload this page.
test: remove unneeded flag check in test-vm-memleak - #34528
Closed
Trott wants to merge 0 commit into
Closed
Conversation
BridgeAR
approved these changes
Jul 27, 2020
lpinca
approved these changes
Jul 27, 2020
Trott
commented
Jul 30, 2020
MemberAuthor
Trott added a commit
to Trott/io.js
that referenced
this pull request
Jul 30, 2020
The `common` module checks that necessary flags are being used, so a check in the test itself is no longer necessary. PR-URL: nodejs#34528 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Trott
commented
Jul 30, 2020
MemberAuthor
Landed in 2d2a812 |
codebytere pushed a commit
that referenced
this pull request
Aug 5, 2020
The `common` module checks that necessary flags are being used, so a check in the test itself is no longer necessary. PR-URL: #34528 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
addaleax pushed a commit
that referenced
this pull request
Sep 22, 2020
The `common` module checks that necessary flags are being used, so a check in the test itself is no longer necessary. PR-URL: #34528 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
addaleax pushed a commit
that referenced
this pull request
Sep 22, 2020
The `common` module checks that necessary flags are being used, so a check in the test itself is no longer necessary. PR-URL: #34528 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
commonmodule checks that necessary flags are being used, so acheck in the test itself is no longer necessary.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes