Uh oh!
There was an error while loading. Please reload this page.
tls: remove util and calls to util.format - #3456
Conversation
MylesBorins
commented
Oct 20, 2015
/cc @jasnell |
There was a problem hiding this comment.
Style nit: line continuations should indent by four spaces. Didn't the linter complain?
There was a problem hiding this comment.
linter did not complain. Fixing this right now.
There was a problem hiding this comment.
So funny enough, if this line is indented an extra two characters it is over 80 :(
There was a problem hiding this comment.
Hah, okay. You can break it in two, i.e.:
reason = `Host: ${host} is not in the cert's altnames: ` +
`${cert.subjectaltname}`;
Fishrock123
commented
Oct 20, 2015
I'm a little concerned this may just be code churn, but it does get rid of the need to escape single quotes and stuff. |
bnoordhuis
commented
Oct 20, 2015
LGTM with a nit. This is the kind of churn I can live with: one less dependency and there are mild performance improvements to be gained. |
MylesBorins
commented
Oct 20, 2015
I'm open to the idea that it might be churn. I would also like to do a perf test to see if switching between util / backticks offers any improvement (could be a perf decrease) |
jasnell
commented
Oct 20, 2015
It's a wee bit churnish but it's the good kind, I think. LGTM |
There was a problem hiding this comment.
You're missing a space between the : and the cert.subjectaltname in the replacement text
bnoordhuis
commented
Oct 20, 2015
I started a node-test-pull-request CI run but I can't link to it. For some reason there's no build history after September 16... |
evanlucas
commented
Oct 20, 2015
evanlucas
commented
Oct 20, 2015
Looks like they are no longer sorted :[ |
MylesBorins
commented
Oct 20, 2015
Is it just me or is that CI run not doing anything? edit: it was just me... sigh |
bnoordhuis
commented
Oct 20, 2015
You have to click through to https://ci.nodejs.org/job/node-test-commit/894/ - some windows failures related to buildbots going AWOL, it seems. |
MylesBorins
commented
Oct 21, 2015
@bnoordhuis should we re run the tests? |
jasnell
commented
Oct 21, 2015
@thealphanerd ... wouldn't hurt to do another run. |
jasnell
commented
Oct 21, 2015
Failures appear to be unrelated. Because this touches tls, @indutny ... quick review? |
Currently util.format is being used for string templating in tls. By replacing all of the instances of util.format with backtick string we can remove the need to require util in tls all together.
MylesBorins
commented
Oct 27, 2015
just rebased against master |
indutny
commented
Oct 27, 2015
LGTM, sorry for delay, the notification was lost in my inbox. |
Trott
commented
Oct 29, 2015
Landed in 6b0c906 |
Currently util.format is being used for string templating in tls. By replacing all of the instances of util.format with backtick string we can remove the need to require util in tls all together. PR-URL: #3456 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Fedor Indutny <fedor@indutny.com>
Currently util.format is being used for string templating in tls. By replacing all of the instances of util.format with backtick string we can remove the need to require util in tls all together. PR-URL: nodejs#3456 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Fedor Indutny <fedor@indutny.com>
rvagg
commented
Oct 30, 2015
suggesting this goes into |
jasnell
commented
Oct 30, 2015
Let's queue this up for post v4.2.2 |
Currently util.format is being used for string templating in tls. By replacing all of the instances of util.format with backtick string we can remove the need to require util in tls all together. PR-URL: #3456 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Fedor Indutny <fedor@indutny.com>
Currently util.format is being used for string templating in tls. By replacing all of the instances of util.format with backtick string we can remove the need to require util in tls all together. PR-URL: #3456 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Fedor Indutny <fedor@indutny.com>
Currently util.format is being used for string templating in tls. By replacing all of the instances of util.format with backtick string we can remove the need to require util in tls all together. PR-URL: #3456 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Fedor Indutny <fedor@indutny.com>
Currently util.format is being used for string templating in tls. By replacing all of the instances of util.format with backtick string we can remove the need to require util in tls all together. PR-URL: #3456 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Fedor Indutny <fedor@indutny.com>
Currently util.format is being used for string templating in tls.
By replacing all of the instances of util.format with backtick
string we can remove the need to require util in tls all together.