Uh oh!
There was an error while loading. Please reload this page.
test: move buffer-as-path symlink test to its own test file - #34569
Closed
Trott wants to merge 0 commit into
Closed
Conversation
Trott
commented
Jul 30, 2020
MemberAuthor
There was a problem hiding this comment.
We don't usually include the Joyent copyright in newly-written tests but this one was substantially copied from test-fs-symlink.js so the copyright is included.
Trott
commented
Aug 1, 2020
MemberAuthor
@nodejs/testing |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Collaborator
rexagod
approved these changes
Aug 1, 2020
This was referenced Aug 2, 2020
This comment has been minimized.
This comment has been minimized.
Collaborator
Trott
commented
Aug 2, 2020
MemberAuthor
@nodejs/fs |
Trott
commented
Aug 2, 2020
MemberAuthor
@nodejs/collaborators This could use another review. |
addaleax
approved these changes
Aug 2, 2020
Flarna
approved these changes
Aug 2, 2020
This was referenced Aug 3, 2020
Trott
commented
Aug 3, 2020
MemberAuthor
Landed in a9c5b87 |
Trott added a commit
that referenced
this pull request
Aug 3, 2020
The buffer-as-path test for fs.symlinkSync() is a bit unusual and potentially error-prone embedded in the general fs.symlink() test. Move it to its own test file. Refs: https://github.com/nodejs/node/pull/34540/files#r463168354 PR-URL: #34569 Reviewed-By: Pranshu Srivastava <rexagod@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
12 tasks
This was referenced Aug 4, 2020
codebytere pushed a commit
that referenced
this pull request
Aug 5, 2020
The buffer-as-path test for fs.symlinkSync() is a bit unusual and potentially error-prone embedded in the general fs.symlink() test. Move it to its own test file. Refs: https://github.com/nodejs/node/pull/34540/files#r463168354 PR-URL: #34569 Reviewed-By: Pranshu Srivastava <rexagod@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
This was referenced Aug 6, 2020
Merged
MylesBorins pushed a commit
that referenced
this pull request
Aug 17, 2020
The buffer-as-path test for fs.symlinkSync() is a bit unusual and potentially error-prone embedded in the general fs.symlink() test. Move it to its own test file. Refs: https://github.com/nodejs/node/pull/34540/files#r463168354 PR-URL: #34569 Reviewed-By: Pranshu Srivastava <rexagod@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Merged
targos pushed a commit
that referenced
this pull request
May 1, 2021
The buffer-as-path test for fs.symlinkSync() is a bit unusual and potentially error-prone embedded in the general fs.symlink() test. Move it to its own test file. Refs: https://github.com/nodejs/node/pull/34540/files#r463168354 PR-URL: #34569 Reviewed-By: Pranshu Srivastava <rexagod@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Merged
danielleadams pushed a commit
that referenced
this pull request
May 8, 2021
The buffer-as-path test for fs.symlinkSync() is a bit unusual and potentially error-prone embedded in the general fs.symlink() test. Move it to its own test file. Refs: https://github.com/nodejs/node/pull/34540/files#r463168354 PR-URL: #34569 Reviewed-By: Pranshu Srivastava <rexagod@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The buffer-as-path test for fs.symlinkSync() is a bit unusual and
potentially error-prone embedded in the general fs.symlink() test. Move
it to its own test file.
Refs: https://github.com/nodejs/node/pull/34540/files#r463168354
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes