Uh oh!
There was an error while loading. Please reload this page.
[v12.x backport] module: deprecate module.parent - #34592
Closed
aduh95 wants to merge 1 commit into
Closed
Conversation
mscdex
reviewed
Aug 1, 2020
Uh oh!
There was an error while loading. Please reload this page.
mscdex
reviewed
Aug 1, 2020
Uh oh!
There was an error while loading. Please reload this page.
aduh95force-pushed
the
backport-32217-to-erbium
branch
from
August 1, 2020 15:19
c57de5a to
6570100Compareaduh95
commented
Aug 10, 2020
ContributorAuthor
@MylesBorins can you please review this? |
MylesBorins
self-requested a review
August 11, 2020 00:34
MylesBorins
commented
Aug 11, 2020
Contributor
I'm unsure if we have prior art in backporting a doc only deprecation. @jasnell @nodejs/tsc thoughts? |
targos
commented
Aug 11, 2020
Member
I think it's fine to backport a doc only deprecation if the suggested alternative is available. |
3 tasks
MylesBorins
commented
Aug 18, 2020
Contributor
If this deprecation was docs only I think I would be less concerned about it. The fact that it makes changes to internals, even if not observable, has me pausing. |
aduh95
commented
Aug 18, 2020
ContributorAuthor
@MylesBorins do you want me to rework the PR to include only doc changes? |
This feature does not work when a module is imported using ECMAScript modules specification, therefore it is deprecated. Fixes: nodejs/modules#469 PR-URL: nodejs#32217 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
aduh95force-pushed
the
backport-32217-to-erbium
branch
from
August 18, 2020 08:46
6570100 to
573ad3eCompareBethGriggs
approved these changes
Aug 18, 2020
richardlau
approved these changes
Aug 18, 2020
ruyadorno
approved these changes
Aug 18, 2020
BethGriggs pushed a commit
that referenced
this pull request
Aug 18, 2020
This feature does not work when a module is imported using ECMAScript modules specification, therefore it is deprecated. Fixes: nodejs/modules#469 PR-URL: #32217 Backport-PR-URL: #34592 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BethGriggs
commented
Aug 18, 2020
Member
Landed in 729799d |
4 tasks
jimmy54 pushed a commit
to jimmy54/nodejs-mobile
that referenced
this pull request
Dec 31, 2025
This feature does not work when a module is imported using ECMAScript modules specification, therefore it is deprecated. Fixes: nodejs/modules#469 PR-URL: nodejs/node#32217 Backport-PR-URL: nodejs/node#34592 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This feature does not work when a module is imported using ECMAScript
modules specification, therefore it is deprecated.
As of v12.17.0, ESM is unflagged for Node.js v12; IMHO it makes sense to backport the doc deprecation.
v14 Backport-PR-URL: #33533
PR-URL: #32217
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes