Skip to content

deps: V8: cherry-pick e06ace6b5cdb - #34673

Closed
addaleax wants to merge 3 commits into
nodejs:masterfrom
addaleax:fix-34606
Closed

deps: V8: cherry-pick e06ace6b5cdb#34673
addaleax wants to merge 3 commits into
nodejs:masterfrom
addaleax:fix-34606

Conversation

@addaleax

@addaleaxaddaleax commented Aug 7, 2020•
edited
Loading

Copy link
Copy Markdown
Member
deps: V8: cherry-pick e06ace6b5cdb

Original commit message:

[api] Fix empty Maybe crash in GetRealNamedPropertyAttributes
`Object::GetRealNamedPropertyAttributes()` can crash if an empty
`Maybe` is returned by `JSReceiver::GetPropertyAttributes()` because
it was not checking for that. Fix that.
Refs: https://github.com/nodejs/node/issues/34606
Change-Id: Ic83f904ba7134786bcd8f786eb2ce98adb4fea1e
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2335057
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/master@{#69258}

Refs: v8/v8@e06ace6
Fixes: #34606

test: add vm crash regression test

Refs: #34606

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@addaleax
deps: V8: cherry-pick e06ace6b5cdb
2b0a451
Original commit message:
[api] Fix empty Maybe crash in GetRealNamedPropertyAttributes
`Object::GetRealNamedPropertyAttributes()` can crash if an empty
`Maybe` is returned by `JSReceiver::GetPropertyAttributes()` because
it was not checking for that. Fix that.
Refs: nodejs#34606
Change-Id: Ic83f904ba7134786bcd8f786eb2ce98adb4fea1e
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2335057
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/master@{#69258}
Refs: v8/v8@e06ace6
@addaleax
test: add vm crash regression test
bd0ccf2
Fixes: nodejs#34606
@addaleaxaddaleax added vm Issues and PRs related to the vm subsystem. v8 engine Issues and PRs related to the V8 dependency. lts-watch-v10.x labels Aug 7, 2020
@nodejs-github-botnodejs-github-bot added the build Issues and PRs related to build files or the CI. label Aug 7, 2020
@addaleaxaddaleax added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 7, 2020
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 7, 2020
@nodejs-github-bot

nodejs-github-bot commented Aug 7, 2020•
edited by addaleax
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32680/ (:green_heart:)

@Trott

Trott commented Aug 10, 2020

Copy link
Copy Markdown
Member

Can this land? Or do V8 changes get some special handling?

addaleax added a commit that referenced this pull request Aug 10, 2020
@addaleax
deps: V8: cherry-pick e06ace6b5cdb
b8b5e1e
Original commit message:
[api] Fix empty Maybe crash in GetRealNamedPropertyAttributes
`Object::GetRealNamedPropertyAttributes()` can crash if an empty
`Maybe` is returned by `JSReceiver::GetPropertyAttributes()` because
it was not checking for that. Fix that.
Refs: #34606
Change-Id: Ic83f904ba7134786bcd8f786eb2ce98adb4fea1e
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2335057
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/master@{#69258}
Refs: v8/v8@e06ace6
PR-URL: #34673Fixes: #34606
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax added a commit that referenced this pull request Aug 10, 2020
@addaleax
test: add vm crash regression test
64acae2
Refs: #34606
PR-URL: #34673
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@addaleax

addaleax commented Aug 10, 2020

Copy link
Copy Markdown
MemberAuthor

Landed in 5b6cd6f...64acae2

@addaleax
addaleax deleted the fix-34606 branch August 10, 2020 15:34
@addaleaxaddaleax mentioned this pull request Aug 10, 2020
Closed
MylesBorins pushed a commit that referenced this pull request Aug 17, 2020
@addaleax@MylesBorins
deps: V8: cherry-pick e06ace6b5cdb
5b2a1f1
Original commit message:
[api] Fix empty Maybe crash in GetRealNamedPropertyAttributes
`Object::GetRealNamedPropertyAttributes()` can crash if an empty
`Maybe` is returned by `JSReceiver::GetPropertyAttributes()` because
it was not checking for that. Fix that.
Refs: #34606
Change-Id: Ic83f904ba7134786bcd8f786eb2ce98adb4fea1e
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2335057
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/master@{#69258}
Refs: v8/v8@e06ace6
PR-URL: #34673Fixes: #34606
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Aug 17, 2020
@addaleax@MylesBorins
test: add vm crash regression test
e4d3dbd
Refs: #34606
PR-URL: #34673
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Aug 20, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Aug 20, 2020
@addaleax@BethGriggs
deps: V8: cherry-pick e06ace6b5cdb
9527a2a
Original commit message:
[api] Fix empty Maybe crash in GetRealNamedPropertyAttributes
`Object::GetRealNamedPropertyAttributes()` can crash if an empty
`Maybe` is returned by `JSReceiver::GetPropertyAttributes()` because
it was not checking for that. Fix that.
Refs: #34606
Change-Id: Ic83f904ba7134786bcd8f786eb2ce98adb4fea1e
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2335057
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/master@{#69258}
Refs: v8/v8@e06ace6
PR-URL: #34673Fixes: #34606
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs pushed a commit that referenced this pull request Aug 20, 2020
@addaleax@BethGriggs
test: add vm crash regression test
27c0653
Refs: #34606
PR-URL: #34673
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this pull request Aug 25, 2020
Danielle Adams
2020-08-25, Version 14.9.0 (Current)
0cb4cbb
Notable changes:
- build: set --v8-enable-object-print by default (Mary Marchini)
[#34705](#34705)
- deps:
- upgrade to libuv 1.39.0 (cjihrig)
[#34915](#34915)
- upgrade npm to 6.14.8 (Ruy Adorno)
[#34834](#34834)
- V8: cherry-pick e06ace6b5cdb (Anna Henningsen)
[#34673](#34673)
- n-api: handle weak no-finalizer refs correctly (Gabriel Schulhof)
[#34839](#34839)
- tools: add debug entitlements for macOS 10.15+ (Gabriele Greco)
[#34378](#34378)
PR-URL: #34852
danielleadams pushed a commit that referenced this pull request Aug 26, 2020
Danielle Adams
2020-08-26, Version 14.9.0 (Current)
9f971f1
Notable changes:
- build: set --v8-enable-object-print by default (Mary Marchini)
[#34705](#34705)
- deps:
- upgrade to libuv 1.39.0 (cjihrig)
[#34915](#34915)
- upgrade npm to 6.14.8 (Ruy Adorno)
[#34834](#34834)
- V8: cherry-pick e06ace6b5cdb (Anna Henningsen)
[#34673](#34673)
- n-api: handle weak no-finalizer refs correctly (Gabriel Schulhof)
[#34839](#34839)
- tools: add debug entitlements for macOS 10.15+ (Gabriele Greco)
[#34378](#34378)
PR-URL: #34852
danielleadams pushed a commit that referenced this pull request Aug 26, 2020
Danielle Adams
2020-08-26, Version 14.9.0 (Current)
cc595f2
Notable changes:
- build: set --v8-enable-object-print by default (Mary Marchini)
[#34705](#34705)
- deps:
- upgrade to libuv 1.39.0 (cjihrig)
[#34915](#34915)
- upgrade npm to 6.14.8 (Ruy Adorno)
[#34834](#34834)
- V8: cherry-pick e06ace6b5cdb (Anna Henningsen)
[#34673](#34673)
- n-api: handle weak no-finalizer refs correctly (Gabriel Schulhof)
[#34839](#34839)
- tools: add debug entitlements for macOS 10.15+ (Gabriele Greco)
[#34378](#34378)
PR-URL: #34852
danielleadams pushed a commit that referenced this pull request Aug 26, 2020
Danielle Adams
2020-08-27, Version 14.9.0 (Current)
7f7d428
Notable changes:
- build: set --v8-enable-object-print by default (Mary Marchini)
[#34705](#34705)
- deps:
- upgrade to libuv 1.39.0 (cjihrig)
[#34915](#34915)
- upgrade npm to 6.14.8 (Ruy Adorno)
[#34834](#34834)
- V8: cherry-pick e06ace6b5cdb (Anna Henningsen)
[#34673](#34673)
- n-api: handle weak no-finalizer refs correctly (Gabriel Schulhof)
[#34839](#34839)
- tools: add debug entitlements for macOS 10.15+ (Gabriele Greco)
[#34378](#34378)
PR-URL: #34852
danielleadams pushed a commit that referenced this pull request Aug 27, 2020
Danielle Adams
2020-08-27, Version 14.9.0 (Current)
3153c2d
Notable changes:
- build: set --v8-enable-object-print by default (Mary Marchini)
[#34705](#34705)
- deps:
- upgrade to libuv 1.39.0 (cjihrig)
[#34915](#34915)
- upgrade npm to 6.14.8 (Ruy Adorno)
[#34834](#34834)
- V8: cherry-pick e06ace6b5cdb (Anna Henningsen)
[#34673](#34673)
- n-api: handle weak no-finalizer refs correctly (Gabriel Schulhof)
[#34839](#34839)
- tools: add debug entitlements for macOS 10.15+ (Gabriele Greco)
[#34378](#34378)
PR-URL: #34852
BethGriggs pushed a commit that referenced this pull request Aug 27, 2020
Danielle Adams@BethGriggs
2020-08-27, Version 14.9.0 (Current)
3089f96
Notable changes:
- build: set --v8-enable-object-print by default (Mary Marchini)
[#34705](#34705)
- deps:
- upgrade to libuv 1.39.0 (cjihrig)
[#34915](#34915)
- upgrade npm to 6.14.8 (Ruy Adorno)
[#34834](#34834)
- V8: cherry-pick e06ace6b5cdb (Anna Henningsen)
[#34673](#34673)
- n-api: handle weak no-finalizer refs correctly (Gabriel Schulhof)
[#34839](#34839)
- tools: add debug entitlements for macOS 10.15+ (Gabriele Greco)
[#34378](#34378)
PR-URL: #34852
targos pushed a commit to targos/node that referenced this pull request Sep 7, 2020
@addaleax@targos
deps: V8: cherry-pick e06ace6b5cdb
148a8fb
Original commit message:
[api] Fix empty Maybe crash in GetRealNamedPropertyAttributes
`Object::GetRealNamedPropertyAttributes()` can crash if an empty
`Maybe` is returned by `JSReceiver::GetPropertyAttributes()` because
it was not checking for that. Fix that.
Refs: nodejs#34606
Change-Id: Ic83f904ba7134786bcd8f786eb2ce98adb4fea1e
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2335057
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/master@{#69258}
Refs: v8/v8@e06ace6
PR-URL: nodejs#34673Fixes: nodejs#34606
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax added a commit that referenced this pull request Sep 27, 2020
@addaleax
deps: V8: cherry-pick e06ace6b5cdb
5a99045
Original commit message:
[api] Fix empty Maybe crash in GetRealNamedPropertyAttributes
`Object::GetRealNamedPropertyAttributes()` can crash if an empty
`Maybe` is returned by `JSReceiver::GetPropertyAttributes()` because
it was not checking for that. Fix that.
Refs: #34606
Change-Id: Ic83f904ba7134786bcd8f786eb2ce98adb4fea1e
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2335057
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/master@{#69258}
Refs: v8/v8@e06ace6
PR-URL: #34673Fixes: #34606
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax added a commit that referenced this pull request Sep 27, 2020
@addaleax
test: add vm crash regression test
20ab2c7
Refs: #34606
PR-URL: #34673
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax added a commit that referenced this pull request Sep 28, 2020
@addaleax
deps: V8: cherry-pick e06ace6b5cdb
4ff6c77
Original commit message:
[api] Fix empty Maybe crash in GetRealNamedPropertyAttributes
`Object::GetRealNamedPropertyAttributes()` can crash if an empty
`Maybe` is returned by `JSReceiver::GetPropertyAttributes()` because
it was not checking for that. Fix that.
Refs: #34606
Change-Id: Ic83f904ba7134786bcd8f786eb2ce98adb4fea1e
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2335057
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/master@{#69258}
Refs: v8/v8@e06ace6
PR-URL: #34673Fixes: #34606
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax added a commit that referenced this pull request Sep 28, 2020
@addaleax
test: add vm crash regression test
3598056
Refs: #34606
PR-URL: #34673
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@codebyterecodebytere mentioned this pull request Sep 28, 2020
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@TrottTrottTrott approved these changes
@gengjiawengengjiawengengjiawen approved these changes

Assignees

No one assigned

Labels

buildIssues and PRs related to build files or the CI.v8 engineIssues and PRs related to the V8 dependency.vmIssues and PRs related to the vm subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Crash at v8::Object::GetRealNamedPropertyAttributes

6 participants

@addaleax@nodejs-github-bot@Trott@jasnell@gengjiawen@MylesBorins