Uh oh!
There was an error while loading. Please reload this page.
v8: pull fix for builtin code size on PPC - #3474
Closed
mhdawson wants to merge 1 commit into
Closed
Conversation
Pull in the change that has been committed to v8 master in https://codereview.chromium.org/1415463002/. We are currently cherry-picking into 4.6 and 4.7 but until next next v8 update into Node Master I'd like to float it as it will make PPC LE go green in the CI
mhdawson
commented
Oct 21, 2015
MemberAuthor
bnoordhuis
commented
Oct 21, 2015
Member
LGTM |
jasnell
commented
Oct 21, 2015
Member
LGTM as well |
mhdawson added a commit
that referenced
this pull request
Oct 22, 2015
Pull in the change that has been committed to v8 master in https://codereview.chromium.org/1415463002/. We are currently cherry-picking into 4.6 and 4.7 but until next next v8 update into Node Master I'd like to float it as it will make PPC LE go green in the CI Fixes: #3390 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <ben@strongloop.com> PR-URL: #3474
jasnell
commented
Oct 22, 2015
Member
mhdawson
commented
Oct 22, 2015
MemberAuthor
The V8 flow is single threaded for pull to previous patches. The first one is in the progress and the second will follow. So should be in 4.6/4.7 within a few days |
mhdawson added a commit
that referenced
this pull request
Oct 26, 2015
Pull in the change that has been committed to v8 master in https://codereview.chromium.org/1415463002/. We are currently cherry-picking into 4.6 and 4.7 but until next next v8 update into Node Master I'd like to float it as it will make PPC LE go green in the CI Fixes: #3390 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <ben@strongloop.com> PR-URL: #3474
This was referenced Oct 27, 2015
jasnell
commented
Oct 28, 2015
Member
@mhdawson ... is this needed in v4.x? |
jasnell
commented
Oct 29, 2015
Member
@john-yan ... do you know if this one is needed in v4.x? |
john-yan
commented
Oct 29, 2015
@jasnell It doesn't harm to include it in v4.x, given that it just increase buffer size. If it fixes any test issue on ppc, I think putting it in is a good idea. |
mhdawson added a commit
that referenced
this pull request
Oct 29, 2015
Pull in the change that has been committed to v8 master in https://codereview.chromium.org/1415463002/. We are currently cherry-picking into 4.6 and 4.7 but until next next v8 update into Node Master I'd like to float it as it will make PPC LE go green in the CI Fixes: #3390 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <ben@strongloop.com> PR-URL: #3474
mhdawson added a commit
that referenced
this pull request
Oct 29, 2015
Pull in the change that has been committed to v8 master in https://codereview.chromium.org/1415463002/. We are currently cherry-picking into 4.6 and 4.7 but until next next v8 update into Node Master I'd like to float it as it will make PPC LE go green in the CI Fixes: #3390 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <ben@strongloop.com> PR-URL: #3474
jasnell
commented
Oct 29, 2015
Member
Landed in v4.x-staging in 5bdb35d |
mhdawson
commented
Oct 30, 2015
MemberAuthor
I don't think we actually needed this since we only saw the issue in 5.X with the newer level of v8. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #3390
Pull in the change that has been committed to v8 master in
https://codereview.chromium.org/1415463002/. We are currently
cherry-picking into 4.6 and 4.7 but until next next v8 update
into Node Master I'd like to float it as it will make PPC LE
go green in the CI