Uh oh!
There was an error while loading. Please reload this page.
doc: move module core module doc to separate page - #34747
Closed
aduh95 wants to merge 4 commits into
Closed
Conversation
nodejs-github-bot
commented
Aug 12, 2020
Collaborator
Review requested:
|
aduh95force-pushed
the
separate-module-core-module-docs
branch
from
August 12, 2020 17:26
90a6282 to
0f741dcCompareThe `module` core module is available for both CJS and ESM users, it deserves its own page.
aduh95force-pushed
the
separate-module-core-module-docs
branch
from
August 12, 2020 17:28
0f741dc to
15c9faeCompare
guybedford
left a comment
Contributor
There was a problem hiding this comment.
I think having the stub links is important for backwards compat with doc links.
Whether this can land depends on feedback from previous contributors here further.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
guybedford
commented
Aug 13, 2020
Contributor
addaleax
approved these changes
Aug 13, 2020
Trott
commented
Aug 14, 2020
Member
@nodejs/documentation @nodejs/website |
jasnell
approved these changes
Aug 19, 2020
jasnell
commented
Aug 19, 2020
Member
Landed in 21abb25 |
jasnell pushed a commit
that referenced
this pull request
Aug 19, 2020
The `module` core module is available for both CJS and ESM users, it deserves its own page. PR-URL: #34747 Refs: nodejs/modules#539 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
3 tasks
BethGriggs pushed a commit
that referenced
this pull request
Aug 20, 2020
The `module` core module is available for both CJS and ESM users, it deserves its own page. PR-URL: #34747 Refs: nodejs/modules#539 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
BethGriggs pushed a commit
that referenced
this pull request
Aug 20, 2020
The `module` core module is available for both CJS and ESM users, it deserves its own page. PR-URL: #34747 Refs: nodejs/modules#539 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Nov 3, 2020
The `module` core module is available for both CJS and ESM users, it deserves its own page. PR-URL: #34747 Refs: nodejs/modules#539 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
MylesBorins pushed a commit
that referenced
this pull request
Nov 16, 2020
The `module` core module is available for both CJS and ESM users, it deserves its own page. PR-URL: #34747 Refs: nodejs/modules#539 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Sep 29, 2022
This was referenced Oct 5, 2022
This was referenced Oct 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
modulecore module is available for both CJS and ESM users, itdeserves its own page.
Refs: nodejs/modules#539
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes