Skip to content

zlib: replace usage of internal stream state with public api - #34884

Closed
lundibundi wants to merge 1 commit into
nodejs:masterfrom
lundibundi:remove-internal-stream-from-zlib
Closed

zlib: replace usage of internal stream state with public api#34884
lundibundi wants to merge 1 commit into
nodejs:masterfrom
lundibundi:remove-internal-stream-from-zlib

Conversation

@lundibundi

@lundibundilundibundi commented Aug 23, 2020

Copy link
Copy Markdown
Member

Refs: #445

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

/cc @nodejs/streams

@lundibundilundibundi added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 23, 2020
@nodejs-github-botnodejs-github-bot added the zlib Issues and PRs related to the zlib subsystem. label Aug 23, 2020
lundibundi
lundibundi commented Aug 23, 2020
View reviewed changes
Comment threadlib/zlib.js
}

if (ws.ended) {
if (this.writableFinished) {

@lundibundilundibundiAug 23, 2020

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC this is slightly off since the .finished will only be set on nextTick but I guess that's okay?
/cc @ronag

@ronagronagAug 23, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

propabbly fine

@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 23, 2020
@nodejs-github-bot

nodejs-github-bot commented Aug 23, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32894/

mcollina
mcollina approved these changes Aug 23, 2020
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.. I would ask for a citgm run.

@lundibundi

lundibundi commented Aug 23, 2020

Copy link
Copy Markdown
MemberAuthor

CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2449/

@ronag

ronag commented Aug 23, 2020

Copy link
Copy Markdown
Member

The docs are rather unclear when exactly callback should be invoked and what that means...

@ronag

This comment has been minimized.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Aug 23, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32906/

@github-actionsgithub-actionsBot mentioned this pull request Aug 24, 2020
Open
10 tasks
This was referenced Aug 25, 2020
Open
Open
@lundibundi

lundibundi commented Aug 26, 2020

Copy link
Copy Markdown
MemberAuthor

Can someone interpret the CITGM run for me, please? Are the failures expected from other changes and this is safe to land or is it the fault of this PR since by the looks of it every more or less recent CITGM run failed.

@github-actionsgithub-actionsBot mentioned this pull request Aug 27, 2020
Open
10 tasks
@mcollina

mcollina commented Aug 27, 2020

Copy link
Copy Markdown
Member

good to go for me

@lundibundilundibundi added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Aug 29, 2020
@github-actionsgithub-actionsBot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 29, 2020
@github-actions

github-actionsBot commented Aug 29, 2020

Copy link
Copy Markdown
Contributor

Landed in 7fca0df

nodejs-github-bot pushed a commit that referenced this pull request Aug 29, 2020
@lundibundi@nodejs-github-bot
zlib: replace usage of internal stream state with public api
7fca0df
Refs: #445
PR-URL: #34884
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@lundibundi
lundibundi deleted the remove-internal-stream-from-zlib branch August 29, 2020 09:44
richardlau pushed a commit that referenced this pull request Sep 1, 2020
@lundibundi@richardlau
zlib: replace usage of internal stream state with public api
94528f5
Refs: #445
PR-URL: #34884
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@richardlaurichardlau mentioned this pull request Sep 2, 2020
Merged
4 tasks
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@lundibundi@addaleax
zlib: replace usage of internal stream state with public api
41361bb
Refs: #445
PR-URL: #34884
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@lundibundi@addaleax
zlib: replace usage of internal stream state with public api
cda459e
Refs: #445
PR-URL: #34884
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@codebyterecodebytere mentioned this pull request Sep 28, 2020
Merged
@Amirali-AmirifarAmirali-Amirifar mentioned this pull request May 1, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ronagronagronag left review comments
@mcollinamcollinamcollina approved these changes
@jasnelljasnelljasnell approved these changes
@addaleaxaddaleaxaddaleax approved these changes
@BridgeARBridgeARBridgeAR approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.zlibIssues and PRs related to the zlib subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@lundibundi@nodejs-github-bot@ronag@mcollina@jasnell@addaleax@BridgeAR