Skip to content

net: replace usage of internal stream state with public api - #34885

Closed
lundibundi wants to merge 1 commit into
nodejs:masterfrom
lundibundi:remove-internal-stream-from-net
Closed

net: replace usage of internal stream state with public api#34885
lundibundi wants to merge 1 commit into
nodejs:masterfrom
lundibundi:remove-internal-stream-from-net

Conversation

@lundibundi

@lundibundilundibundi commented Aug 23, 2020

Copy link
Copy Markdown
Member

Refs: #445

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

/cc @nodejs/net

@lundibundilundibundi added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 23, 2020
@lundibundi
lundibundi requested a review from a team as a code ownerAugust 23, 2020 08:49
@lundibundi
lundibundi requested a review from a teamAugust 23, 2020 08:49
@nodejs-github-botnodejs-github-bot added the net Issues and PRs related to the net subsystem. label Aug 23, 2020
@nodejs-github-bot

nodejs-github-bot commented Aug 23, 2020

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/net
  • @nodejs/quic

@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 23, 2020
@nodejs-github-bot

nodejs-github-bot commented Aug 23, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32895/

mcollina
mcollina approved these changes Aug 23, 2020
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nodejs-github-bot

nodejs-github-bot commented Aug 23, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32905/

@github-actionsgithub-actionsBot mentioned this pull request Aug 24, 2020
Open
10 tasks
This was referenced Aug 25, 2020
Open
Open
Open
@lundibundilundibundi added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Aug 29, 2020
@github-actionsgithub-actionsBot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 29, 2020
@github-actions

github-actionsBot commented Aug 29, 2020

Copy link
Copy Markdown
Contributor

Landed in a36b7d8

nodejs-github-bot pushed a commit that referenced this pull request Aug 29, 2020
@lundibundi@nodejs-github-bot
net: replace usage of internal stream state with public api
a36b7d8
Refs: #445
PR-URL: #34885
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
@lundibundi
lundibundi deleted the remove-internal-stream-from-net branch August 29, 2020 09:44
richardlau pushed a commit that referenced this pull request Sep 1, 2020
@lundibundi@richardlau
net: replace usage of internal stream state with public api
fcb211f
Refs: #445
PR-URL: #34885
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
@richardlaurichardlau mentioned this pull request Sep 2, 2020
Merged
4 tasks
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@lundibundi@addaleax
net: replace usage of internal stream state with public api
1d0a8b7
Refs: #445
PR-URL: #34885
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@lundibundi@addaleax
net: replace usage of internal stream state with public api
3c4abe0
Refs: #445
PR-URL: #34885
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
@codebyterecodebytere mentioned this pull request Sep 28, 2020
Merged
This was referenced May 27, 2022
Open
Open
@137717unity137717unity mentioned this pull request May 27, 2022
Open
@baby636baby636 mentioned this pull request May 27, 2022
Open
@snyk-botsnyk-bot mentioned this pull request May 27, 2022
Open
@wedataintelligencewedataintelligence mentioned this pull request May 27, 2022
Open
@ron-a20ron-a20 mentioned this pull request May 27, 2022
Open
@molllyn1molllyn1 mentioned this pull request May 28, 2022
Open
@snyk-botsnyk-bot mentioned this pull request Sep 25, 2022
Open
@wedataintelligencewedataintelligence mentioned this pull request Sep 26, 2022
Open
@137717unity137717unity mentioned this pull request Sep 26, 2022
Open
@snyk-botsnyk-bot mentioned this pull request Sep 27, 2022
Open
@wedataintelligencewedataintelligence mentioned this pull request Sep 29, 2022
Open
This was referenced Sep 29, 2022
Open
Open
This was referenced Oct 5, 2022
Open
Open
@snyk-botsnyk-bot mentioned this pull request Oct 6, 2022
Open
@137717unity137717unity mentioned this pull request Oct 7, 2022
Open
@wedataintelligencewedataintelligence mentioned this pull request Oct 7, 2022
Open
This was referenced Oct 8, 2022
Open
Open
@137717unity137717unity mentioned this pull request Oct 9, 2022
Open
@snyk-botsnyk-bot mentioned this pull request Oct 9, 2022
Open
@kissofirekissofire mentioned this pull request Jun 25, 2023
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes
@addaleaxaddaleaxaddaleax approved these changes
@lpincalpincalpinca approved these changes
+1 more reviewer
@rickyesrickyesrickyes approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.netIssues and PRs related to the net subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@lundibundi@nodejs-github-bot@mcollina@addaleax@lpinca@rickyes