Skip to content

doc: make minor improvements to query string sentence in http2.md - #34929

Merged
Trott merged 1 commit into
nodejs:masterfrom
Trott:obtain
Aug 29, 2020
Merged

doc: make minor improvements to query string sentence in http2.md#34929
Trott merged 1 commit into
nodejs:masterfrom
Trott:obtain

Conversation

@Trott

Copy link
Copy Markdown
Member
Checklist

@Trott
Trott requested review from a team as code ownersAugust 26, 2020 05:41
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/http
  • @nodejs/http2
  • @nodejs/net

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. http2 Issues or PRs related to the http2 subsystem. labels Aug 26, 2020
Comment threaddoc/api/http2.md Outdated
@TrottTrott added the review wanted PRs that need reviews. label Aug 29, 2020
PR-URL: nodejs#34929
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
@Trott

Copy link
Copy Markdown
MemberAuthor

Landed in c2996ce

@Trott
Trott merged commit c2996ce into nodejs:masterAug 29, 2020
@Trott
Trott deleted the obtain branch August 29, 2020 15:01
Trott added a commit to Trott/io.js that referenced this pull request Aug 30, 2020
Refs: nodejs#34929 (comment)
PR-URL: nodejs#34956
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
richardlau pushed a commit that referenced this pull request Sep 1, 2020
PR-URL: #34929
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
richardlau pushed a commit that referenced this pull request Sep 1, 2020
Refs: #34929 (comment)
PR-URL: #34956
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
@richardlaurichardlau mentioned this pull request Sep 2, 2020
4 tasks
addaleax pushed a commit that referenced this pull request Sep 22, 2020
PR-URL: #34929
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
PR-URL: #34929
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
@codebyterecodebytere mentioned this pull request Sep 28, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docIssues and PRs related to the documentations.http2Issues or PRs related to the http2 subsystem.review wantedPRs that need reviews.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@Trott@nodejs-github-bot@lundibundi@rickyes