Uh oh!
There was an error while loading. Please reload this page.
http2,tls: account for buffered data before creating socket wraps - #34958
Closed
addaleax wants to merge 3 commits into
Closed
http2,tls: account for buffered data before creating socket wraps#34958addaleax wants to merge 3 commits into
addaleax wants to merge 3 commits into
Conversation
nodejs-github-bot
commented
Aug 28, 2020
Collaborator
Review requested:
|
nodejs-github-bot
commented
Aug 28, 2020
Collaborator
nodejs-github-bot
commented
Aug 28, 2020
Collaborator
mcollina
approved these changes
Aug 28, 2020
Uh oh!
There was an error while loading. Please reload this page.
3 tasks
Collaborator
If there is data stored in the socket, create a `JSStreamSocket` wrapper so that no data is lost when passing the socket to the C++ layer (which is unaware of data buffered in JS land). Refs: nodejs#34532
If there is data stored in the socket, create a `JSStreamSocket` wrapper so that no data is lost when passing the socket to the C++ layer (which is unaware of data buffered in JS land). Fixes: nodejs#34532
nodejs-github-bot
commented
Oct 6, 2020
Collaborator
addaleax
commented
Oct 6, 2020
MemberAuthor
Yeah, I just rebased to remember why this was failing :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
stream: allow using.push()/.unshift()duringonce('data')See #34957 (which this PR is blocked on)tls: account for buffered data before creating TLSSocket wrap
If there is data stored in the socket, create a
JSStreamSocketwrapper so that no data is lost when passing the socket to the
C++ layer (which is unaware of data buffered in JS land).
Refs: #34532
http2: account for buffered data before creating HTTP2 socket wrap
If there is data stored in the socket, create a
JSStreamSocketwrapper so that no data is lost when passing the socket to the
C++ layer (which is unaware of data buffered in JS land).
Fixes: #34532
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes