Skip to content

test: remove incorrect debug() in test-policy-integrity - #34961

Merged
Trott merged 1 commit into
nodejs:masterfrom
Trott:policy-integrity
Sep 2, 2020
Merged

test: remove incorrect debug() in test-policy-integrity#34961
Trott merged 1 commit into
nodejs:masterfrom
Trott:policy-integrity

Conversation

@Trott

@TrottTrott commented Aug 28, 2020

Copy link
Copy Markdown
Member

The instructions to use test:policy-integrity:NUMBER do not work, I'm
afraid. This removes them.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@Trott
Trott requested a review from bmeckAugust 28, 2020 21:56
@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Aug 28, 2020
@Trott

Trott commented Aug 28, 2020

Copy link
Copy Markdown
MemberAuthor

/ping @bmeck, just in case I got it wrong here, but I don't think I did?

@Trott

Trott commented Aug 28, 2020

Copy link
Copy Markdown
MemberAuthor

Pummel CI: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/16175/

@TrottTrott added the review wanted PRs that need reviews. label Aug 30, 2020
@Trott

Trott commented Sep 1, 2020

Copy link
Copy Markdown
MemberAuthor

@nodejs/collaborators This could use some reviews.

ryzokuken
ryzokuken approved these changes Sep 1, 2020
View reviewed changes

@ryzokukenryzokuken left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@puzpuzpuz
puzpuzpuz self-requested a review September 1, 2020 06:49
@TrottTrott added request-ci Add this label to start a Jenkins CI on a PR. and removed review wanted PRs that need reviews. labels Sep 1, 2020
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 1, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@richardlau

richardlau commented Sep 1, 2020

Copy link
Copy Markdown
Member

Commit subsystem should be "test" instead of "doc".

@TrottTrott changed the title doc: remove incorrect debug() in test-policy-integritytest: remove incorrect debug() in test-policy-integritySep 1, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Sep 1, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32995/

@Trott

Trott commented Sep 2, 2020

Copy link
Copy Markdown
MemberAuthor

Pummel CI: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/16218/

@nodejs-github-bot

nodejs-github-bot commented Sep 2, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32999/

@Trott
test: remove incorrect debug() in test-policy-integrity
4f7440c
The instructions to use `test:policy-integrity:NUMBER` do not work, I'm
afraid. This removes them.
PR-URL: nodejs#34961
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@Trott
Trott merged commit 4f7440c into nodejs:masterSep 2, 2020
@Trott

Trott commented Sep 2, 2020

Copy link
Copy Markdown
MemberAuthor

Landed in 4f7440c

@Trott
Trott deleted the policy-integrity branch September 2, 2020 13:56
richardlau pushed a commit that referenced this pull request Sep 2, 2020
@Trott@richardlau
test: remove incorrect debug() in test-policy-integrity
12115e1
The instructions to use `test:policy-integrity:NUMBER` do not work, I'm
afraid. This removes them.
PR-URL: #34961
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@richardlaurichardlau mentioned this pull request Sep 2, 2020
Merged
4 tasks
richardlau pushed a commit that referenced this pull request Sep 3, 2020
@Trott@richardlau
test: remove incorrect debug() in test-policy-integrity
b698d2e
The instructions to use `test:policy-integrity:NUMBER` do not work, I'm
afraid. This removes them.
PR-URL: #34961
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@Trott@addaleax
test: remove incorrect debug() in test-policy-integrity
c2a3314
The instructions to use `test:policy-integrity:NUMBER` do not work, I'm
afraid. This removes them.
PR-URL: #34961
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@Trott@addaleax
test: remove incorrect debug() in test-policy-integrity
0bd1768
The instructions to use `test:policy-integrity:NUMBER` do not work, I'm
afraid. This removes them.
PR-URL: #34961
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@codebyterecodebytere mentioned this pull request Sep 28, 2020
Merged
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
@Trott@joesepi
test: remove incorrect debug() in test-policy-integrity
2ef967b
The instructions to use `test:policy-integrity:NUMBER` do not work, I'm
afraid. This removes them.
PR-URL: nodejs#34961
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@targostargostargos approved these changes
@richardlaurichardlaurichardlau approved these changes
@himself65himself65himself65 approved these changes
@trivikrtrivikrtrivikr approved these changes
+3 more reviewers
@bmeckbmeckbmeck approved these changes
@ryzokukenryzokukenryzokuken approved these changes
@puzpuzpuzpuzpuzpuzpuzpuzpuz approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@Trott@nodejs-github-bot@richardlau@bmeck@targos@ryzokuken@himself65@trivikr@puzpuzpuz