Uh oh!
There was an error while loading. Please reload this page.
doc: recommend URL() over url.parse() in http2 doc - #34978
Merged
Conversation
nodejs-github-bot
commented
Aug 29, 2020
Collaborator
Review requested:
|
addaleax
approved these changes
Aug 29, 2020
targos
approved these changes
Aug 31, 2020
Trottforce-pushed
the
url-no-parse
branch
2 times, most recently
from
September 1, 2020 02:53
f59cd32 to
811a0f9ComparePR-URL: nodejs#34978 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Trott
commented
Sep 1, 2020
MemberAuthor
Landed in 492c34f |
richardlau pushed a commit
that referenced
this pull request
Sep 1, 2020
PR-URL: #34978 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist