Skip to content

buffer: fix value check for writeUInt{B,L}E - #3500

Closed
trevnorris wants to merge 1 commit into
nodejs:masterfrom
trevnorris:buf-fix-uint-write
Closed

buffer: fix value check for writeUInt{B,L}E#3500
trevnorris wants to merge 1 commit into
nodejs:masterfrom
trevnorris:buf-fix-uint-write

Conversation

@trevnorris

@trevnorristrevnorris commented Oct 23, 2015

Copy link
Copy Markdown
Contributor

bnoordhuis
bnoordhuis reviewed Oct 23, 2015
View reviewed changes
Comment threadlib/buffer.js Outdated

@bnoordhuisbnoordhuisOct 23, 2015

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Crankshaft and TurboFan are smart enough to move the Math.pow() call to the use site but the baseline compiler probably isn't, which would mean an extra Math.pow() call in the (unoptimized) common case.

@trevnorristrevnorrisOct 23, 2015

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh whoops. I just moved it b/c it didn't fit in 80 chars, but brain farted that i moved it outside the if. will fix.

@mscdexmscdex added the buffer Issues and PRs related to the buffer subsystem. label Oct 23, 2015
@jasnell

jasnell commented Oct 26, 2015

Copy link
Copy Markdown
Member

@trevnorris ... would you want this in v4.x?

@trevnorris

trevnorris commented Oct 26, 2015

Copy link
Copy Markdown
ContributorAuthor

@jasnell bug fix, so I think so.

@trevnorris

trevnorris commented Oct 26, 2015

Copy link
Copy Markdown
ContributorAuthor

@bnoordhuis Addressed comments.

New CI: https://ci.nodejs.org/job/node-test-pull-request/620/

@trevnorris

trevnorris commented Oct 26, 2015

Copy link
Copy Markdown
ContributorAuthor

Two unrelated failures. Everything else looks good.

@trevnorris
trevnorrisforce-pushed the buf-fix-uint-write branch 2 times, most recently from 540da8d to 67d4e96CompareOctober 26, 2015 20:10
@bnoordhuis

bnoordhuis commented Oct 26, 2015

Copy link
Copy Markdown
Member

LGTM. Consider adding tests for byteLength > 1.

@trevnorris

trevnorris commented Oct 26, 2015

Copy link
Copy Markdown
ContributorAuthor

@bnoordhuis do these (https://github.com/nodejs/node/pull/3500/files#diff-aa771a8dc1afdde910c49517a74a0ddeR143) not cover that?

@bnoordhuis

bnoordhuis commented Oct 26, 2015

Copy link
Copy Markdown
Member

I only see tests for byteLength == 0 and 1 or am I missing something?

trevnorris added a commit that referenced this pull request Oct 26, 2015
@trevnorris
buffer: fix value check for writeUInt{B,L}E
3308e5e
Fixes: #3497
PR-URL: #3500
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@trevnorris

trevnorris commented Oct 26, 2015

Copy link
Copy Markdown
ContributorAuthor

Thanks for the review. Landed in 3308e5e.

@trevnorris
trevnorris deleted the buf-fix-uint-write branch October 26, 2015 20:59
trevnorris added a commit that referenced this pull request Oct 26, 2015
@trevnorris@rvagg
buffer: fix value check for writeUInt{B,L}E
6a04cc0
Fixes: #3497
PR-URL: #3500
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@rvaggrvagg mentioned this pull request Oct 27, 2015
Merged
trevnorris added a commit that referenced this pull request Oct 28, 2015
@trevnorris@jasnell
buffer: fix value check for writeUInt{B,L}E
bc2120c
Fixes: #3497
PR-URL: #3500
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@jasnell

jasnell commented Oct 28, 2015

Copy link
Copy Markdown
Member

Landed in v4.x-staging bc2120c

@rvaggrvagg mentioned this pull request Oct 28, 2015
Closed
trevnorris added a commit that referenced this pull request Oct 29, 2015
@trevnorris@jasnell
buffer: fix value check for writeUInt{B,L}E
1d0f2cb
Fixes: #3497
PR-URL: #3500
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@jasnelljasnell mentioned this pull request Oct 29, 2015
Closed
This was referenced Apr 29, 2023
Open
Open
This was referenced Jun 22, 2023
Open
Open
Open
Open
Open
@leonardoadameleonardoadame mentioned this pull request Jul 9, 2023
Open
@alisccoaliscco mentioned this pull request Oct 27, 2023
Open
@alisccoaliscco mentioned this pull request Nov 28, 2023
Open
This was referenced Nov 29, 2023
Open
Open
@alisccoaliscco mentioned this pull request Dec 2, 2023
Open
@leonardoadameleonardoadame mentioned this pull request Dec 3, 2023
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bufferIssues and PRs related to the buffer subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@trevnorris@jasnell@bnoordhuis@mscdex