Skip to content

doc: use consistent header typography - #35030

Merged
Trott merged 1 commit into
nodejs:masterfrom
Trott:backticks-err
Sep 5, 2020
Merged

doc: use consistent header typography#35030
Trott merged 1 commit into
nodejs:masterfrom
Trott:backticks-err

Conversation

@Trott

@TrottTrott commented Sep 3, 2020

Copy link
Copy Markdown
Member

Adding backticks to an entry that has them missing in the header, unlike
the other entries.

Checklist

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. errors Issues and PRs related to JavaScript errors originated in Node.js core. labels Sep 3, 2020
@Trott

Trott commented Sep 4, 2020

Copy link
Copy Markdown
MemberAuthor

@nodejs/documentation

@DerekNonGenericDerekNonGeneric left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find.

Adding backticks to an entry that has them missing in the header, unlike
the other entries.
PR-URL: nodejs#35030
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@Trott

Trott commented Sep 5, 2020

Copy link
Copy Markdown
MemberAuthor

Landed in 66f62b3

@Trott
Trott merged commit 66f62b3 into nodejs:masterSep 5, 2020
@Trott
Trott deleted the backticks-err branch September 5, 2020 13:54
richardlau pushed a commit that referenced this pull request Sep 7, 2020
Adding backticks to an entry that has them missing in the header, unlike
the other entries.
PR-URL: #35030
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@richardlaurichardlau mentioned this pull request Sep 7, 2020
4 tasks
richardlau pushed a commit that referenced this pull request Sep 7, 2020
Adding backticks to an entry that has them missing in the header, unlike
the other entries.
PR-URL: #35030
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
Adding backticks to an entry that has them missing in the header, unlike
the other entries.
PR-URL: #35030
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
Adding backticks to an entry that has them missing in the header, unlike
the other entries.
PR-URL: #35030
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@codebyterecodebytere mentioned this pull request Sep 28, 2020
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
Adding backticks to an entry that has them missing in the header, unlike
the other entries.
PR-URL: nodejs#35030
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.errorsIssues and PRs related to JavaScript errors originated in Node.js core.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@Trott@addaleax@targos@DerekNonGeneric@nodejs-github-bot