Skip to content

doc: change color contrast for accessibility - #35047

Merged
Trott merged 0 commit into
nodejs:masterfrom
Trott:stability-1-color
Sep 4, 2020
Merged

doc: change color contrast for accessibility#35047
Trott merged 0 commit into
nodejs:masterfrom
Trott:stability-1-color

Conversation

@Trott

@TrottTrott commented Sep 4, 2020

Copy link
Copy Markdown
Member

Change background color of Stability 1 banner. Previous color contrast
of 3.61:1 fails WCAG AA. New color contrast of 4.50:1 passes.

Checklist

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Sep 4, 2020
@Trott

Trott commented Sep 4, 2020

Copy link
Copy Markdown
MemberAuthor

Before:

image

After:

image

@Trott

Trott commented Sep 4, 2020

Copy link
Copy Markdown
MemberAuthor

@nodejs/website

ryzokuken
ryzokuken approved these changes Sep 4, 2020
View reviewed changes

@ryzokukenryzokuken left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this change!

MylesBorins
MylesBorins approved these changes Sep 4, 2020
View reviewed changes

@MylesBorinsMylesBorins left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MylesBorins

MylesBorins commented Sep 4, 2020

Copy link
Copy Markdown
Contributor

fast track?

@MylesBorinsMylesBorins added the fast-track PRs that do not need to wait for 48 hours to land. label Sep 4, 2020
@Trott

Trott commented Sep 4, 2020

Copy link
Copy Markdown
MemberAuthor

Landed in f3b4846

@TrottTrott closed this Sep 4, 2020
@Trott
Trott merged commit f3b4846 into nodejs:masterSep 4, 2020
@Trott
Trott deleted the stability-1-color branch September 4, 2020 22:53
richardlau pushed a commit that referenced this pull request Sep 7, 2020
@Trott@richardlau
doc: change color contrast for accessibility
0e8a592
Change background color of Stability 1 banner. Previous color contrast
of 3.61:1 fails WCAG AA. New color contrast of 4.50:1 passes.
PR-URL: #35047
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
@richardlaurichardlau mentioned this pull request Sep 7, 2020
Merged
4 tasks
richardlau pushed a commit that referenced this pull request Sep 7, 2020
@Trott@richardlau
doc: change color contrast for accessibility
593236a
Change background color of Stability 1 banner. Previous color contrast
of 3.61:1 fails WCAG AA. New color contrast of 4.50:1 passes.
PR-URL: #35047
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@Trott@addaleax
doc: change color contrast for accessibility
c83859e
Change background color of Stability 1 banner. Previous color contrast
of 3.61:1 fails WCAG AA. New color contrast of 4.50:1 passes.
PR-URL: #35047
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@Trott@addaleax
doc: change color contrast for accessibility
2529ba2
Change background color of Stability 1 banner. Previous color contrast
of 3.61:1 fails WCAG AA. New color contrast of 4.50:1 passes.
PR-URL: #35047
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
@codebyterecodebytere mentioned this pull request Sep 28, 2020
Merged
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
@Trott@joesepi
doc: change color contrast for accessibility
b0744b8
Change background color of Stability 1 banner. Previous color contrast
of 3.61:1 fails WCAG AA. New color contrast of 4.50:1 passes.
PR-URL: nodejs#35047
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@codebyterecodebyterecodebytere approved these changes
@tniessentniessentniessen approved these changes
+5 more reviewers
@csabapalficsabapalficsabapalfi approved these changes
@XhmikosRXhmikosRXhmikosR approved these changes
@MylesBorinsMylesBorinsMylesBorins approved these changes
@ryzokukenryzokukenryzokuken approved these changes
@DerekNonGenericDerekNonGenericDerekNonGeneric approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docIssues and PRs related to the documentations.fast-trackPRs that do not need to wait for 48 hours to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@Trott@MylesBorins@csabapalfi@XhmikosR@codebytere@tniessen@ryzokuken@DerekNonGeneric@nodejs-github-bot