Uh oh!
There was an error while loading. Please reload this page.
crypto: align parameter names with documentation - #35054
Merged
Merged
Conversation
nodejs-github-bot
commented
Sep 4, 2020
Collaborator
Review requested:
|
tniessen
approved these changes
Sep 4, 2020
This comment has been minimized.
This comment has been minimized.
targos
approved these changes
Sep 6, 2020
nodejs-github-bot
commented
Sep 6, 2020
Collaborator
Trott
commented
Sep 6, 2020
MemberAuthor
Landed in 53f7d3e |
richardlau pushed a commit
that referenced
this pull request
Sep 7, 2020
Change _cb_ to _callback_ to align with documentation. This is so that stack traces and error messages align with the documentation. If the documentation says "callback", then the stack traces and error messages should indicate that "callback" needs to be function or whatever, rather than "cb". PR-URL: #35054 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com>
richardlau pushed a commit
that referenced
this pull request
Sep 7, 2020
Change _cb_ to _callback_ to align with documentation. This is so that stack traces and error messages align with the documentation. If the documentation says "callback", then the stack traces and error messages should indicate that "callback" needs to be function or whatever, rather than "cb". PR-URL: #35054 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com>
addaleax pushed a commit
that referenced
this pull request
Sep 22, 2020
Change _cb_ to _callback_ to align with documentation. This is so that stack traces and error messages align with the documentation. If the documentation says "callback", then the stack traces and error messages should indicate that "callback" needs to be function or whatever, rather than "cb". PR-URL: #35054 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Merged
joesepi pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
Change _cb_ to _callback_ to align with documentation. This is so that stack traces and error messages align with the documentation. If the documentation says "callback", then the stack traces and error messages should indicate that "callback" needs to be function or whatever, rather than "cb". PR-URL: nodejs#35054 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change cb to callback to align with documentation. This is so that
stack traces and error messages align with the documentation. If the
documentation says "callback", then the stack traces and error messages
should indicate that "callback" needs to be function or whatever, rather
than "cb".
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes