esm: remove unused function argument

[Trott]

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines

[nodejs-github-bot]

Review requested:

• @nodejs/modules

[guybedford]

I believe this used to be to provide the "importer" information in the error message on failure, which is important in esm because we don't have a require stack.

I just checked this and can verify that for package.json with invalid syntax that importing in that directory gives the invalid syntax error without the name context of the parent module.

I would prefer if we could rather refactor getPackageConfig to support the " imported from ${base}" error context here rather than remove this context.

[Trott]

I just checked this and can verify that for package.json with invalid syntax that importing in that directory gives the invalid syntax error without the name context of the parent module.

Are you referring to ERR_INVALID_PACKAGE_CONFIG or something else? I'm not sure if I'm following what you're saying.

[Trott]

(And if this is one of those things that would be easier/faster to just do yourself than explain to me, don't let me stop you.)

[guybedford]

I just had a deeper look at this and there are two main cases for the ERR_INVALID_PACKAGE_CONFIG error:

1. import 'pkg' doing a node_modules lookup for the package will read the package.json, then throw this error if it has invalid syntax
2. import './path/to/module.js' will do a package.json lookup for the module format of the JS file and will throw this error if the package.json file has invalid syntax

For case (1), useful context is the parent importer loading the package.
For case (2), useful context is the module that was loaded that caused the package.json to be checked.

Both of these are actually slightly different messages though. I've gone ahead and put together a nicer context for these messages in #35117.