Skip to content

fix: only set keep-alive when not exists - #35096

Closed
atian25 wants to merge 0 commit into
nodejs:masterfrom
atian25:master
Closed

fix: only set keep-alive when not exists#35096
atian25 wants to merge 0 commit into
nodejs:masterfrom
atian25:master

Conversation

@atian25

@atian25atian25 commented Sep 8, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor
  • only set Keep-Alive once
  • set Keep-Alive with correct ms

fix: #34561 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@atian25
atian25 requested a review from a team as a code ownerSeptember 8, 2020 07:41
@nodejs-github-bot

nodejs-github-bot commented Sep 8, 2020

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/http
  • @nodejs/net

@nodejs-github-botnodejs-github-bot added the http Issues or PRs related to the http subsystem. label Sep 8, 2020
@atian25atian25 mentioned this pull request Sep 8, 2020
Closed
4 tasks
@atian25
atian25force-pushed the master branch 2 times, most recently from 30638d4 to f3f40c3CompareSeptember 8, 2020 07:59
@atian25atian25 mentioned this pull request Sep 8, 2020
Merged
4 tasks
rickyes
rickyes approved these changes Sep 8, 2020
View reviewed changes

@rickyesrickyes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rickyesrickyes added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 8, 2020
ronag
ronag reviewed Sep 8, 2020
View reviewed changes
Comment threadlib/_http_outgoing.js Outdated
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 8, 2020
@nodejs-github-bot

nodejs-github-bot commented Sep 8, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33098/

@rickyesrickyes added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 8, 2020
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 8, 2020
@nodejs-github-bot

nodejs-github-bot commented Sep 8, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33100/

@rickyesrickyes added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 9, 2020
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 9, 2020
@nodejs-github-bot

nodejs-github-bot commented Sep 9, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33104/

@rickyesrickyes added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 9, 2020
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 9, 2020
@nodejs-github-bot

nodejs-github-bot commented Sep 9, 2020•
edited by rickyes
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33106/ ✅

@pullpullBot closed this Sep 10, 2020
This was referenced Sep 10, 2020
Closed
Closed
@atian25atian25 mentioned this pull request Oct 10, 2020
Closed
4 tasks
@wedataintelligencewedataintelligence mentioned this pull request Nov 30, 2023
Open
@aliceUnhinged613aliceUnhinged613 mentioned this pull request Nov 30, 2023
Open
@baby636baby636 mentioned this pull request Dec 1, 2023
Open
@aliceUnhinged613aliceUnhinged613 mentioned this pull request May 13, 2024
Open
@molllyn1molllyn1 mentioned this pull request May 13, 2024
Open
@ron-a20ron-a20 mentioned this pull request May 13, 2024
Open
@137717unity137717unity mentioned this pull request May 14, 2024
Open
@baby636baby636 mentioned this pull request May 14, 2024
Open
@wedataintelligencewedataintelligence mentioned this pull request May 14, 2024
Open
@aliceUnhinged613aliceUnhinged613 mentioned this pull request May 15, 2024
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ronagronagronag approved these changes
@lpincalpincalpinca approved these changes
+1 more reviewer
@rickyesrickyesrickyes approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

httpIssues or PRs related to the http subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@atian25@nodejs-github-bot@lpinca@ronag@rickyes