Uh oh!
There was an error while loading. Please reload this page.
buffer: adjust validation to account for buffer.kMaxLength - #35134
Closed
addaleax wants to merge 1 commit into
Closed
buffer: adjust validation to account for buffer.kMaxLength#35134addaleax wants to merge 1 commit into
addaleax wants to merge 1 commit into
Conversation
Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/33119/ (:green_heart:) |
BridgeAR
approved these changes
Sep 10, 2020
jasnell
approved these changes
Sep 11, 2020
ZYSzys
approved these changes
Sep 11, 2020
Contributor
Landed in 3c56463 |
nodejs-github-bot pushed a commit
that referenced
this pull request
Sep 12, 2020
PR-URL: #35134 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
ruyadorno pushed a commit
that referenced
this pull request
Sep 17, 2020
PR-URL: #35134 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
joesepi pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
PR-URL: nodejs#35134 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes