Uh oh!
There was an error while loading. Please reload this page.
doc: fix left nav color contrast - #35141
Merged
Merged
Conversation
Trott
commented
Sep 10, 2020
MemberAuthor
Before: After: |
Trott
commented
Sep 10, 2020
MemberAuthor
@nodejs/website |
osk2
approved these changes
Sep 10, 2020
watilde
approved these changes
Sep 10, 2020
benjamingr
approved these changes
Sep 10, 2020
joesepi
approved these changes
Sep 10, 2020
DerekNonGeneric
approved these changes
Sep 10, 2020
trivikr
approved these changes
Sep 10, 2020
aymen94
approved these changes
Sep 11, 2020
Trott
commented
Sep 12, 2020
MemberAuthor
Landed in 4fdc5ac |
I believe this is the last change to make in the docs for color contrast accessibility per WCAG AA. Currently, the current item in the nav is #43853d on a #333333 background for a color contrast of 2.8:1, failing WCAG AA. This swaps in removes a confusing bottom border on the item, replacing it with bolding to preserve the item's highlighting. PR-URL: nodejs#35141 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
ruyadorno pushed a commit
that referenced
this pull request
Sep 17, 2020
I believe this is the last change to make in the docs for color contrast accessibility per WCAG AA. Currently, the current item in the nav is #43853d on a #333333 background for a color contrast of 2.8:1, failing WCAG AA. This swaps in removes a confusing bottom border on the item, replacing it with bolding to preserve the item's highlighting. PR-URL: #35141 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
addaleax pushed a commit
that referenced
this pull request
Sep 22, 2020
I believe this is the last change to make in the docs for color contrast accessibility per WCAG AA. Currently, the current item in the nav is #43853d on a #333333 background for a color contrast of 2.8:1, failing WCAG AA. This swaps in removes a confusing bottom border on the item, replacing it with bolding to preserve the item's highlighting. PR-URL: #35141 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
joesepi pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
I believe this is the last change to make in the docs for color contrast accessibility per WCAG AA. Currently, the current item in the nav is #43853d on a #333333 background for a color contrast of 2.8:1, failing WCAG AA. This swaps in removes a confusing bottom border on the item, replacing it with bolding to preserve the item's highlighting. PR-URL: nodejs#35141 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe this is the last change to make in the docs for color contrast
accessibility per WCAG AA.
Currently, the current item in the nav is #43853d on a #333333
background for a color contrast of 2.8:1, failing WCAG AA. This swaps in
removes a confusing bottom border on the item, replacing it with
bolding to preserve the item's highlighting.
Checklist