Uh oh!
There was an error while loading. Please reload this page.
doc: remove http2 non-link anchor tags - #35161
Conversation
nodejs-github-bot
commented
Sep 12, 2020
Review requested:
|
Trott
commented
Sep 12, 2020
addaleax
commented
Sep 12, 2020
I kind of wish we’d go into the opposite direction more often – these anchor tags allow creating permanently functional links from other websites to the documentation, while the automatically generated anchors can easily change even when only a minor change to the header text was performed and break those links. I would keep them. |
Trott
commented
Sep 12, 2020
I can definitely support that to accommodate links from external pages, but these were apparently created to have links from within the page, and I'm not sure we want to encourage that. |
Trott
commented
Sep 14, 2020
Landed in b569376 |
Headers have ids automatically assigned. Removed ad hoc ids using anchor tags that aren't links. PR-URL: nodejs#35161 Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
ruyadorno
commented
Sep 15, 2020
this change doesn't land cleanly on v14.x, should it be backported? |
Headers have ids automatically assigned. Removed ad hoc ids using anchor tags that aren't links. PR-URL: nodejs#35161 Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Trott
commented
Sep 25, 2020
@ruyadorno Backport in #35334. |
Headers have ids automatically assigned. Removed ad hoc ids using anchor tags that aren't links. PR-URL: nodejs#35161 Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Headers have ids automatically assigned. Removed ad hoc ids using anchor
tags that aren't links.
Checklist