Skip to content

test: add wasi readdir() test - #35202

Closed
cjihrig wants to merge 1 commit into
nodejs:masterfrom
cjihrig:readdir
Closed

test: add wasi readdir() test#35202
cjihrig wants to merge 1 commit into
nodejs:masterfrom
cjihrig:readdir

Conversation

@cjihrig

@cjihrigcjihrig commented Sep 15, 2020

Copy link
Copy Markdown
Contributor

This commit provides coverage for __wasi_fd_readdir().

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@cjihrig
test: add wasi readdir() test
3f040fc
This commit provides coverage for __wasi_fd_readdir().
@nodejs-github-bot

nodejs-github-bot commented Sep 15, 2020

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/wasi

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Sep 15, 2020
@gengjiawengengjiawen added the wasi Issues and PRs related to the WebAssembly System Interface. label Sep 16, 2020
@gengjiawengengjiawen added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 16, 2020
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 16, 2020
@nodejs-github-bot

nodejs-github-bot commented Sep 16, 2020•
edited by cjihrig
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33146/ 💚

@cjihrigcjihrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Sep 16, 2020
@github-actionsgithub-actionsBot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 17, 2020
@github-actions

github-actionsBot commented Sep 17, 2020

Copy link
Copy Markdown
Contributor

Landed in c314c04

nodejs-github-bot pushed a commit that referenced this pull request Sep 17, 2020
@cjihrig@nodejs-github-bot
test: add wasi readdir() test
c314c04
This commit provides coverage for __wasi_fd_readdir().
PR-URL: #35202
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@cjihrig
cjihrig deleted the readdir branch September 17, 2020 19:02
ruyadorno pushed a commit that referenced this pull request Sep 21, 2020
@cjihrig@ruyadorno
test: add wasi readdir() test
8357b56
This commit provides coverage for __wasi_fd_readdir().
PR-URL: #35202
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@ruyadornoruyadorno mentioned this pull request Sep 21, 2020
Merged
4 tasks
MylesBorins pushed a commit that referenced this pull request Nov 3, 2020
@cjihrig@MylesBorins
test: add wasi readdir() test
eb33501
This commit provides coverage for __wasi_fd_readdir().
PR-URL: #35202
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Nov 3, 2020
Merged
MylesBorins pushed a commit that referenced this pull request Nov 16, 2020
@cjihrig@MylesBorins
test: add wasi readdir() test
c3e1bf7
This commit provides coverage for __wasi_fd_readdir().
PR-URL: #35202
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
@cjihrig@joesepi
test: add wasi readdir() test
6fa7864
This commit provides coverage for __wasi_fd_readdir().
PR-URL: nodejs#35202
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleaxaddaleaxaddaleax approved these changes
@gengjiawengengjiawengengjiawen approved these changes
+1 more reviewer
@devsnekdevsnekdevsnek approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.testIssues and PRs related to the tests.wasiIssues and PRs related to the WebAssembly System Interface.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cjihrig@nodejs-github-bot@addaleax@gengjiawen@devsnek