Uh oh!
There was an error while loading. Please reload this page.
build: add Commit Queue actions url to failure comment - #35206
Closed
lundibundi wants to merge 1 commit into
Closed
Conversation
mmarchini
approved these changes
Sep 15, 2020
| gitHubCurl "$(labelsUrl "$pr")" POST --data '{"labels": ["'"${COMMIT_QUEUE_FAILED_LABEL}"'"]}' | ||
| jq -n --arg content "<details><summary>Commit Queue failed</summary><pre>$(cat output)</pre></details>" '{body: $content}' > output.json | ||
| cqurl="Commit Queue action: $GITHUB_SERVER_URL/${OWNER}/${REPOSITORY}/actions/runs/$GITHUB_RUN_ID" |
Contributor
There was a problem hiding this comment.
This variable could be set outside the for loop, but there's no harm in having it here so 🤷♀️
MemberAuthor
There was a problem hiding this comment.
I agree, but since this is bash and everything is kind of 'messy' (imo) I'd prefer to have it right beside the place of usage if you don't mind.
richardlau
approved these changes
Sep 16, 2020
4 tasks
aduh95
approved these changes
Oct 7, 2020
aduh95 pushed a commit
to nodejs/node-auto-test
that referenced
this pull request
Oct 9, 2020
PR-URL: nodejs/node#35206 Refs: https://docs.github.com/en/actions/configuring-and-managing-workflows/using-environment-variables Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This comment has been minimized.
This comment has been minimized.
nodejs-github-bot
commented
Oct 9, 2020
Collaborator
nodejs-github-bot
commented
Oct 9, 2020
Collaborator
mmarchini
commented
Oct 9, 2020
Contributor
Landed in 5509c1b |
mmarchini pushed a commit
that referenced
this pull request
Oct 9, 2020
PR-URL: #35206 Refs: https://docs.github.com/en/actions/configuring-and-managing-workflows/using-environment-variables Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95
commented
Oct 11, 2020
Contributor
This seems to be broken: #35570 (comment) |
3 tasks
BethGriggs pushed a commit
that referenced
this pull request
Oct 14, 2020
PR-URL: #35206 Refs: https://docs.github.com/en/actions/configuring-and-managing-workflows/using-environment-variables Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Trott pushed a commit
to aduh95/node
that referenced
this pull request
Oct 14, 2020
Refs: nodejs#35206 PR-URL: nodejs#35599 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
joesepi pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
PR-URL: nodejs#35206 Refs: https://docs.github.com/en/actions/configuring-and-managing-workflows/using-environment-variables Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
joesepi pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
Refs: nodejs#35206 PR-URL: nodejs#35599 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesRefs: https://docs.github.com/en/actions/configuring-and-managing-workflows/using-environment-variables
Refs: #34770 (comment)
NOT TESTED YET. I guess I should land this to
node-auto-testto verify that it works?/cc @mmarchini