Skip to content

doc: update releaser in v12.18.4 changelog - #35217

Closed
BethGriggs wants to merge 1 commit into
nodejs:masterfrom
BethGriggs:v12.18.4-changelog
Closed

doc: update releaser in v12.18.4 changelog#35217
BethGriggs wants to merge 1 commit into
nodejs:masterfrom
BethGriggs:v12.18.4-changelog

Conversation

@BethGriggs

Copy link
Copy Markdown
Member
Checklist

(Just a retrospective update to reflect who promoted/signed the release.)

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Sep 15, 2020
@targostargos added the fast-track PRs that do not need to wait for 48 hours to land. label Sep 16, 2020
@targos

Copy link
Copy Markdown
Member

fast-track?

@richardlaurichardlau added commit-queue Add this label to land a pull request using GitHub Actions. lts-watch-v12.x labels Sep 16, 2020
@github-actionsgithub-actionsBot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 16, 2020
@github-actions

Copy link
Copy Markdown
Contributor

Landed in 524123f

nodejs-github-bot pushed a commit that referenced this pull request Sep 16, 2020
PR-URL: #35217
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@ruyadorno

Copy link
Copy Markdown
Member

Adding dont-land-on-v14.x label since I noticed this is bringing in tons of unrelated changes to doc/changelogs/CHANGELOG_V12.md.

Changelog files of older release lines don't seem to usually be touched due to us using branch-diff --filter-release on the release workflow.

MylesBorins pushed a commit that referenced this pull request Nov 16, 2020
PR-URL: #35217
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 16, 2020
PR-URL: #35217
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@MylesBorinsMylesBorins mentioned this pull request Nov 16, 2020
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
PR-URL: nodejs#35217
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docIssues and PRs related to the documentations.fast-trackPRs that do not need to wait for 48 hours to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@BethGriggs@targos@ruyadorno@cjihrig@richardlau@MylesBorins@nodejs-github-bot