Uh oh!
There was an error while loading. Please reload this page.
[v14.x backport] doc: use present tense in error messages - #35247
Closed
Trott wants to merge 1 commit into
Closed
Conversation
Error messages are a mix of present and past tense. They should be mostly or entirely present tense. This eliminates the past tense constructions "was found" and "were found". PR-URL: nodejs#35164 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2 tasks
ruyadorno
approved these changes
Sep 21, 2020
ruyadorno pushed a commit
that referenced
this pull request
Sep 22, 2020
Error messages are a mix of present and past tense. They should be mostly or entirely present tense. This eliminates the past tense constructions "was found" and "were found". Backport-PR-URL: #35247 PR-URL: #35164 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
ruyadorno
commented
Sep 22, 2020
Member
Landed in 836680a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Error messages are a mix of present and past tense. They should be
mostly or entirely present tense. This eliminates the past tense
constructions "was found" and "were found".
PR-URL: #35164
Reviewed-By: Anna Henningsen anna@addaleax.net
Reviewed-By: Denys Otrishko shishugi@gmail.com
Reviewed-By: Derek Lewis DerekNonGeneric@inf.is
Reviewed-By: Luigi Pinca luigipinca@gmail.com
Checklist