Uh oh!
There was an error while loading. Please reload this page.
doc: clarify napi_property_attributes text - #35253
Closed
Trott wants to merge 1 commit into
Closed
Conversation
* Rearrange sentence to avoid ambiguity whether the entire sentence applies to a method in a JS class or just the "but not" part * Use serial comma * Correct spelling of _configurable_
nodejs-github-bot
commented
Sep 18, 2020
Collaborator
Review requested:
|
legendecas
approved these changes
Sep 18, 2020
NickNaso
approved these changes
Sep 18, 2020
Flarna
approved these changes
Sep 19, 2020
lpinca
approved these changes
Sep 19, 2020
addaleax
approved these changes
Sep 20, 2020
Contributor
Commit Queue failed- Loading data for nodejs/node/pull/35253 ✔ Done loading data for nodejs/node/pull/35253 ----------------------------------- PR info ------------------------------------ Title doc: clarify napi_property_attributes text (#35253) Author Rich Trott (@Trott) Branch Trott:napi-prop-text -> nodejs:master Labels doc, n-api Commits 1 - doc: clarify napi_property_attributes text Committers 1 - Rich Trott PR-URL: https://github.com/nodejs/node/pull/35253 Reviewed-By: Chengzhong Wu Reviewed-By: Michael Dawson Reviewed-By: Gerhard Stöbich Reviewed-By: Luigi Pinca Reviewed-By: Anna Henningsen ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/35253 Reviewed-By: Chengzhong Wu Reviewed-By: Michael Dawson Reviewed-By: Gerhard Stöbich Reviewed-By: Luigi Pinca Reviewed-By: Anna Henningsen -------------------------------------------------------------------------------- ✖ GitHub CI is still running ℹ Doc-only changes ℹ This PR was created on Fri, 18 Sep 2020 09:31:48 GMT ✔ Approvals: 5 ✔ - Chengzhong Wu (@legendecas): https://github.com/nodejs/node/pull/35253#pullrequestreview-491314856 ✔ - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/35253#pullrequestreview-491579392 ✔ - Gerhard Stöbich (@Flarna): https://github.com/nodejs/node/pull/35253#pullrequestreview-491983778 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/35253#pullrequestreview-492128499 ✔ - Anna Henningsen (@addaleax): https://github.com/nodejs/node/pull/35253#pullrequestreview-492198585 -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu |
addaleax
commented
Sep 20, 2020
Member
Landed in 62ff691 |
addaleax pushed a commit
that referenced
this pull request
Sep 20, 2020
* Rearrange sentence to avoid ambiguity whether the entire sentence applies to a method in a JS class or just the "but not" part * Use serial comma * Correct spelling of _configurable_ PR-URL: #35253 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
ruyadorno pushed a commit
that referenced
this pull request
Sep 21, 2020
* Rearrange sentence to avoid ambiguity whether the entire sentence applies to a method in a JS class or just the "but not" part * Use serial comma * Correct spelling of _configurable_ PR-URL: #35253 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
joesepi pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
* Rearrange sentence to avoid ambiguity whether the entire sentence applies to a method in a JS class or just the "but not" part * Use serial comma * Correct spelling of _configurable_ PR-URL: nodejs#35253 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
applies to a method in a JS class or just the "but not" part
Checklist