Skip to content

readline: fix key name for function keys combined with modifiers - #35268

Merged
Trott merged 1 commit into
nodejs:masterfrom
elie-g:fix-emitted-key-name
Sep 21, 2020
Merged

readline: fix key name for function keys combined with modifiers#35268
Trott merged 1 commit into
nodejs:masterfrom
elie-g:fix-emitted-key-name

Conversation

@elie-g

@elie-gelie-g commented Sep 19, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

Added proper key names for function key (e.g. F4) combined with modifiers (e.g. Ctrl).

I also added support for:

  • Alt + Enter
  • Alt + KeypadEnter
  • Alt + Backspace

Fixes#35251

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the readline Issues and PRs related to the built-in readline module. label Sep 19, 2020
@elie-gelie-g mentioned this pull request Sep 19, 2020
Open
@addaleaxaddaleax added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 20, 2020
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 20, 2020
@nodejs-github-bot

nodejs-github-bot commented Sep 20, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33173/

@elie-g@Trott
readline: fix key name for function keys with modifiers
17ebd46
Fixes: nodejs#35251
PR-URL: nodejs#35268
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Trott
Trottforce-pushed the fix-emitted-key-name branch from 4002565 to 17ebd46CompareSeptember 21, 2020 14:44
@Trott
Trott merged commit 17ebd46 into nodejs:masterSep 21, 2020
@Trott

Trott commented Sep 21, 2020

Copy link
Copy Markdown
Member

Landed in 17ebd46

@Trott

Trott commented Sep 21, 2020

Copy link
Copy Markdown
Member

Thanks for the contribution! 🎉

@elie-g
elie-g deleted the fix-emitted-key-name branch September 21, 2020 14:48
@elie-g

elie-g commented Sep 21, 2020•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@Trott@addaleax@joyeecheung
Is it normal that key.name can have both undefined (e.g. when you press the period. key) and the string "undefined" as value (see here) ?

PS: I didn't want to open an new issue just for this, I'm not even sure if it's really an issue.

@addaleax

addaleax commented Sep 21, 2020

Copy link
Copy Markdown
Member

@DrunkenPoney That doesn’t sound intentional to me, no. Feel free to fix this if you like 👍

ruyadorno pushed a commit that referenced this pull request Sep 21, 2020
@elie-g@ruyadorno
readline: fix key name for function keys with modifiers
4f4faa8
Fixes: #35251
PR-URL: #35268
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@ruyadornoruyadorno mentioned this pull request Sep 21, 2020
Merged
4 tasks
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
@elie-g@joesepi
readline: fix key name for function keys with modifiers
2203dc2
Fixes: nodejs#35251
PR-URL: nodejs#35268
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrottTrottTrott approved these changes
@addaleaxaddaleaxaddaleax approved these changes
@joyeecheungjoyeecheungjoyeecheung approved these changes

Assignees

No one assigned

Labels

readlineIssues and PRs related to the built-in readline module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Readline: Function keys (e.g. F1) return "undefined" key name

5 participants

@elie-g@nodejs-github-bot@Trott@addaleax@joyeecheung