Skip to content

doc: update message to match actual output - #35271

Merged
Trott merged 1 commit into
nodejs:masterfrom
Trott:debugger-Ctrl-plus
Apr 27, 2021
Merged

doc: update message to match actual output#35271
Trott merged 1 commit into
nodejs:masterfrom
Trott:debugger-Ctrl-plus

Conversation

@Trott

Copy link
Copy Markdown
Member
Checklist

@nodejs-github-botnodejs-github-bot added debugger doc Issues and PRs related to the documentations. labels Sep 19, 2020
@Trott
Trott marked this pull request as draft September 19, 2020 16:23
@Trott
Trott marked this pull request as ready for review September 19, 2020 16:23
@TrottTrott added the blocked PRs that are blocked by other issues or PRs. label Sep 19, 2020
@Trott

Copy link
Copy Markdown
MemberAuthor

This is blocked until nodejs/node-inspect#89 lands and makes it into our deps.

@lpinca

Copy link
Copy Markdown
Member

@Trottnodejs/node-inspect#89 landed. Can the blocked label be removed?

@Trott

Trott commented Oct 5, 2020

Copy link
Copy Markdown
MemberAuthor

@Trottnodejs/node-inspect#89 landed. Can the blocked label be removed?

Not until there's a node-inspect release and we incorporate that release into deps/node-inspect.

@targostargos added inspector Issues and PRs related to the V8 inspector protocol and removed debugger labels Dec 27, 2020
@TrottTrott removed the blocked PRs that are blocked by other issues or PRs. label Apr 27, 2021
@Trott

Copy link
Copy Markdown
MemberAuthor

Required change just landed a few minutes ago.

@Trott
Trottforce-pushed the debugger-Ctrl-plus branch from 5dac6cb to 4e7f654CompareApril 27, 2021 16:03
PR-URL: nodejs#35271
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@Trott
Trottforce-pushed the debugger-Ctrl-plus branch from 4e7f654 to 50bbc4eCompareApril 27, 2021 16:05
@Trott

Copy link
Copy Markdown
MemberAuthor

Landed in 50bbc4e

@Trott
Trott merged commit 50bbc4e into nodejs:masterApr 27, 2021
@Trott
Trott deleted the debugger-Ctrl-plus branch April 27, 2021 16:05
targos pushed a commit that referenced this pull request Apr 29, 2021
PR-URL: #35271
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@targostargos mentioned this pull request May 3, 2021
targos pushed a commit that referenced this pull request May 30, 2021
PR-URL: #35271
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
targos pushed a commit that referenced this pull request Jun 5, 2021
PR-URL: #35271
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
targos pushed a commit that referenced this pull request Jun 5, 2021
PR-URL: #35271
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@targostargos mentioned this pull request Jun 6, 2021
targos pushed a commit that referenced this pull request Jun 11, 2021
PR-URL: #35271
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docIssues and PRs related to the documentations.inspectorIssues and PRs related to the V8 inspector protocol

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@Trott@lpinca@tniessen@targos@nodejs-github-bot