Skip to content

doc: update AUTHORS list - #35280

Closed
addaleax wants to merge 2 commits into
nodejs:masterfrom
addaleax:update-authors
Closed

doc: update AUTHORS list#35280
addaleax wants to merge 2 commits into
nodejs:masterfrom
addaleax:update-authors

Conversation

@addaleax

@addaleaxaddaleax commented Sep 21, 2020

Copy link
Copy Markdown
Member
Checklist

@nodejs-github-botnodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Sep 21, 2020
addaleax
addaleax commented Sep 21, 2020
View reviewed changes
Comment thread.mailmap
Ron Korving <ron@ronkorving.nl> <rkorving@wizcorp.jp>
Ron Korving <ron@ronkorving.nl> ronkorving <ron@ronkorving.nl>
Ruben Bridgewater <ruben@bridgewater.de> <ruben.bridgewater@fintura.de>
Ruben Bridgewater <ruben@bridgewater.de> <ruben.bridgewater@maibornwolff.de>

@addaleaxaddaleaxSep 21, 2020

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BridgeAR Is this still the address you prefer?

addaleax
addaleax commented Sep 21, 2020
View reviewed changes
Comment thread.mailmap
@richardlau

richardlau commented Sep 21, 2020

Copy link
Copy Markdown
Member

FWIW there were some duplicates identified in #34694 that still apply.

addaleax
addaleax commented Sep 21, 2020
View reviewed changes
Comment threadAUTHORS Outdated
addaleax
addaleax commented Sep 21, 2020
View reviewed changes
Comment threadAUTHORS
Bartlomiej Brzozowski <bart.brzozowski@janeasystems.com>
Saajan <saajan.sn@gmail.com>
Yash Ladha <yashladhapankajladha123@gmail.com>
Xu Meng <dmabupt@gmail.com>

@addaleaxaddaleaxSep 21, 2020

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dmabupt Which is your preferred address?

mhdawson
mhdawson approved these changes Sep 22, 2020
View reviewed changes

@mhdawsonmhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Trott
Trott approved these changes Sep 23, 2020
View reviewed changes

@TrottTrott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber-stamp LGTM

@lpincalpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 4, 2020
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 4, 2020
@nodejs-github-bot

nodejs-github-bot commented Oct 4, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33369/

MylesBorins
MylesBorins approved these changes Oct 5, 2020
View reviewed changes
Comment thread.mailmap
Comment on lines +286 to +288
Myles Borins <mylesborins@github.com> <mborins@us.ibm.com>
Myles Borins <mylesborins@github.com> <mylesborins@google.com>
Myles Borins <mylesborins@github.com> <myles.borins@gmail.com>

@MylesBorinsMylesBorinsOct 5, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It me!

TYVM

@addaleaxaddaleax added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 5, 2020
@github-actionsgithub-actionsBot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 5, 2020
@github-actions

github-actionsBot commented Oct 5, 2020

Copy link
Copy Markdown
Contributor

Landed in dd571ca

nodejs-github-bot pushed a commit that referenced this pull request Oct 5, 2020
@addaleax@nodejs-github-bot
doc: update AUTHORS list
dd571ca
PR-URL: #35280
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@lpincalpinca mentioned this pull request Oct 5, 2020
Closed
4 tasks
@danielleadamsdanielleadams mentioned this pull request Oct 6, 2020
Merged
danielleadams pushed a commit that referenced this pull request Oct 6, 2020
@addaleax@danielleadams
doc: update AUTHORS list
f08577c
PR-URL: #35280
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 3, 2020
@addaleax@MylesBorins
doc: update AUTHORS list
8d4b0c3
PR-URL: #35280
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Nov 3, 2020
Merged
MylesBorins pushed a commit that referenced this pull request Nov 16, 2020
@addaleax@MylesBorins
doc: update AUTHORS list
b5f7525
PR-URL: #35280
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
@addaleax@joesepi
doc: update AUTHORS list
6c750e5
PR-URL: nodejs#35280
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrottTrottTrott approved these changes
@benjamingrbenjamingrbenjamingr approved these changes
@watildewatildewatilde approved these changes
@gireeshpunathilgireeshpunathilgireeshpunathil approved these changes
+4 more reviewers
@Nibbler999Nibbler999Nibbler999 left review comments
@MylesBorinsMylesBorinsMylesBorins approved these changes
@mhdawsonmhdawsonmhdawson approved these changes
@crypt096crypt096crypt096 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

metaIssues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

12 participants

@addaleax@richardlau@nodejs-github-bot@MylesBorins@Trott@Nibbler999@benjamingr@watilde@gireeshpunathil@mhdawson@crypt096@lpinca