Uh oh!
There was an error while loading. Please reload this page.
doc: fix heading whitespace bug in assert.md - #35310
Merged
Merged
Conversation
tlhunter
commented
Sep 23, 2020
ContributorAuthor
Before: |
richardlau
approved these changes
Sep 23, 2020
Trott
approved these changes
Sep 23, 2020
Trott
commented
Sep 23, 2020
Member
That's char code 160, a non-breaking space. We should probably add that to our prohibited strings setup in remark-preset-lint-node and suggest people use a space character or |
Trott
commented
Sep 23, 2020
Member
Fast-track? |
Fixing a heading rendering bug PR-URL: nodejs#35310 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Trott
commented
Sep 23, 2020
Member
Landed in d6fe46f |
MylesBorins pushed a commit
that referenced
this pull request
Sep 24, 2020
Fixing a heading rendering bug PR-URL: #35310 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
joesepi pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
Fixing a heading rendering bug PR-URL: nodejs#35310 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing a heading rendering bug, looks like an invalid whitespace character was used, causing the docs to display three # symbols.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes