Skip to content

[v12.x] fs: implement lutimes - #35320

Closed
addaleax wants to merge 3 commits into
nodejs:v12.x-stagingfrom
addaleax:backport-v12.x-33399
Closed

[v12.x] fs: implement lutimes#35320
addaleax wants to merge 3 commits into
nodejs:v12.x-stagingfrom
addaleax:backport-v12.x-33399

Conversation

@addaleax

Copy link
Copy Markdown
Member

Backport of #33399, applies cleanly except for the fixup commit below

PR-URL: nodejs#33399
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
@addaleaxaddaleax added fs Issues and PRs related to the fs subsystem / file system. semver-minor PRs that contain new features and should be released in the next minor version. v12.x labels Sep 23, 2020
@nodejs-github-botnodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Sep 23, 2020
@addaleaxaddaleax mentioned this pull request Sep 23, 2020
4 tasks
@addaleaxaddaleax added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 23, 2020
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 23, 2020
@nodejs-github-bot

This comment has been minimized.

@addaleaxaddaleax added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 23, 2020
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 23, 2020
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Comment threaddoc/api/fs.md Outdated
addaleax added a commit to addaleax/node that referenced this pull request Sep 24, 2020
@addaleaxaddaleax mentioned this pull request Sep 24, 2020
3 tasks
@addaleaxaddaleax added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Sep 24, 2020
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 24, 2020
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

nodejs-github-bot pushed a commit that referenced this pull request Sep 24, 2020
Refs: #35320 (comment)
PR-URL: #35328
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@addaleax

Copy link
Copy Markdown
MemberAuthor

Landed in a19933f

addaleax pushed a commit that referenced this pull request Sep 25, 2020
PR-URL: #33399
Backport-PR-URL: #35320
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
@addaleax
addaleax deleted the backport-v12.x-33399 branch September 25, 2020 14:51
MylesBorins pushed a commit that referenced this pull request Sep 29, 2020
Refs: #35320 (comment)
PR-URL: #35328
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
Refs: nodejs#35320 (comment)
PR-URL: nodejs#35328
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.fsIssues and PRs related to the fs subsystem / file system.semver-minorPRs that contain new features and should be released in the next minor version.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@addaleax@nodejs-github-bot@richardlau@Flarna@arcanis