Skip to content

doc: stream write(chunk, encoding, cb) encoding can be null - #35372

Merged
aduh95 merged 1 commit into
nodejs:masterfrom
dev-script:doc/stream-write-encoding
Nov 9, 2020
Merged

doc: stream write(chunk, encoding, cb) encoding can be null#35372
aduh95 merged 1 commit into
nodejs:masterfrom
dev-script:doc/stream-write-encoding

Conversation

@dev-script

@dev-scriptdev-script commented Sep 27, 2020

Copy link
Copy Markdown
Contributor

In stream write encoding can be null.

Fixes: #33715

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem. labels Sep 27, 2020
@dev-scriptdev-script mentioned this pull request Sep 27, 2020
Closed
3 tasks
@mscdex

mscdex commented Sep 27, 2020

Copy link
Copy Markdown
Contributor

The targeted subsystem in the commit message should be doc instead of stream.

@dev-scriptdev-script changed the title stream: write(chunk, encoding, cb) encoding can be nulldoc: write(chunk, encoding, cb) encoding can be nullSep 27, 2020
@dev-scriptdev-script changed the title doc: write(chunk, encoding, cb) encoding can be nulldoc: stream write(chunk, encoding, cb) encoding can be nullSep 27, 2020
@dev-script

dev-script commented Sep 27, 2020

Copy link
Copy Markdown
ContributorAuthor

The targeted subsystem in the commit message should be doc instead of stream.

I have done changes. please review

@lpinca

lpinca commented Sep 30, 2020

Copy link
Copy Markdown
Member

Any falsy value for the encoding argument works in the same way.

node/lib/internal/streams/writable.js

Lines 293 to 294 in ee9e3e7

if(!encoding)
encoding=state.defaultEncoding;

Not sure if it is ok to add only null.

@aduh95aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 8, 2020
@aduh95
aduh95force-pushed the doc/stream-write-encoding branch from d4a718d to 934faa0CompareNovember 9, 2020 18:13
@dev-script@aduh95
doc,stream: write(chunk, encoding, cb) encoding can be null
caa5a05
In stream write encoding can be null.
Fixes: nodejs#33715
PR-URL: nodejs#35372
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@aduh95
aduh95force-pushed the doc/stream-write-encoding branch from 934faa0 to caa5a05CompareNovember 9, 2020 18:15
@aduh95

aduh95 commented Nov 9, 2020

Copy link
Copy Markdown
Contributor

Landed in caa5a05

@aduh95
aduh95 merged commit caa5a05 into nodejs:masterNov 9, 2020
danielleadams pushed a commit that referenced this pull request Nov 9, 2020
@dev-script@danielleadams
doc,stream: write(chunk, encoding, cb) encoding can be null
36c20d9
In stream write encoding can be null.
Fixes: #33715
PR-URL: #35372
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Nov 9, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Dec 9, 2020
@dev-script@BethGriggs
doc,stream: write(chunk, encoding, cb) encoding can be null
ddec68a
In stream write encoding can be null.
Fixes: #33715
PR-URL: #35372
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
@dev-script@BethGriggs
doc,stream: write(chunk, encoding, cb) encoding can be null
62741b5
In stream write encoding can be null.
Fixes: #33715
PR-URL: #35372
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@BethGriggsBethGriggs mentioned this pull request Dec 10, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Dec 15, 2020
@dev-script@BethGriggs
doc,stream: write(chunk, encoding, cb) encoding can be null
0a944a4
In stream write encoding can be null.
Fixes: #33715
PR-URL: #35372
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aduh95aduh95aduh95 approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.streamIssues and PRs related to the stream subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

A possible TODO list for new (or current) contributors

5 participants

@dev-script@mscdex@lpinca@aduh95@nodejs-github-bot