Skip to content

[v12.x] http: add maxTotalSockets to agent class - #35396

Closed
rickyes wants to merge 2 commits into
nodejs:v12.x-stagingfrom
rickyes:backport-maxTotalSockets-to-v12.x
Closed

[v12.x] http: add maxTotalSockets to agent class#35396
rickyes wants to merge 2 commits into
nodejs:v12.x-stagingfrom
rickyes:backport-maxTotalSockets-to-v12.x

Conversation

@rickyes

@rickyesrickyes commented Sep 28, 2020

Copy link
Copy Markdown
Contributor

Add maxTotalSockets to determine how many sockets an agent can open.
Unlike maxSockets, The maxTotalSockets does not count by per origin.

PR-URL: #33617
PR-URL: #34013
Fixes: #31942
Reviewed-By: @ronag
Reviewed-By: @mcollina
Reviewed-By: @jasnell

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@rickyes
http: add maxTotalSockets to agent class
6933e00
Add maxTotalSockets to determine how many sockets an agent can open.
Unlike maxSockets, The maxTotalSockets does not count by per origin.
PR-URL: nodejs#33617Fixes: nodejs#31942
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@rickyes
doc: Add maxTotalSockets option to agent constructor
0a507d1
PR-URL: nodejs#34013
Refs: nodejs#33617
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@rickyes
rickyes requested a review from a team as a code ownerSeptember 28, 2020 12:57
@nodejs-github-bot

nodejs-github-bot commented Sep 28, 2020

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/http
  • @nodejs/net

@nodejs-github-botnodejs-github-bot added http Issues or PRs related to the http subsystem. v12.x labels Sep 28, 2020
@rickyesrickyes mentioned this pull request Sep 28, 2020
Closed
4 tasks
@addaleaxaddaleax added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 28, 2020
@rickyesrickyes mentioned this pull request Sep 28, 2020
Closed
2 tasks
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 28, 2020
@nodejs-github-bot

nodejs-github-bot commented Sep 28, 2020•
edited by rickyes
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33277/ ✅

@addaleax

addaleax commented Sep 28, 2020

Copy link
Copy Markdown
Member

Landed in b9d0f73...1a8669d

addaleax pushed a commit that referenced this pull request Sep 28, 2020
@rickyes@addaleax
http: add maxTotalSockets to agent class
3d1bdc2
Add maxTotalSockets to determine how many sockets an agent can open.
Unlike maxSockets, The maxTotalSockets does not count by per origin.
PR-URL: #33617
Backport-PR-URL: #35396Fixes: #31942
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit that referenced this pull request Sep 28, 2020
@rickyes@addaleax
doc: Add maxTotalSockets option to agent constructor
1a8669d
PR-URL: #34013
Backport-PR-URL: #35396
Refs: #33617
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #33617Fixes: #31942
@rickyes
rickyes deleted the backport-maxTotalSockets-to-v12.x branch September 29, 2020 00:17
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

httpIssues or PRs related to the http subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rickyes@nodejs-github-bot@addaleax