Skip to content

doc,crypto: added sign/verify method changes about dsaEncoding - #35480

Closed
panva wants to merge 1 commit into
nodejs:masterfrom
panva:dsa-encoding-doc
Closed

doc,crypto: added sign/verify method changes about dsaEncoding#35480
panva wants to merge 1 commit into
nodejs:masterfrom
panva:dsa-encoding-doc

Conversation

@panva

@panvapanva commented Oct 3, 2020

Copy link
Copy Markdown
Member

This adds the sign/verify method addition of dsaEncoding from #29292 to the docs.

Checklist

@nodejs-github-botnodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. labels Oct 3, 2020
@panvapanva changed the title Dsa encoding docdoc,crypto: added sign/verify method changes about dsaEncodingOct 3, 2020
lpinca
lpinca approved these changes Oct 3, 2020
View reviewed changes

@lpincalpinca left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only nits to be consistent with #35454.

Comment threaddoc/api/crypto.md Outdated
Comment threaddoc/api/crypto.md Outdated
Comment threaddoc/api/crypto.md Outdated
Comment threaddoc/api/crypto.md Outdated
@panva

panva commented Oct 3, 2020

Copy link
Copy Markdown
MemberAuthor

CI Failure unrelated to the changes.

@panva

panva commented Nov 2, 2020

Copy link
Copy Markdown
MemberAuthor

🚢 ?

@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Nov 8, 2020
@github-actionsgithub-actionsBot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 8, 2020
@github-actions

github-actionsBot commented Nov 8, 2020

Copy link
Copy Markdown
Contributor

Landed in f06f3c0...1f69aa0

nodejs-github-bot pushed a commit that referenced this pull request Nov 8, 2020
@panva@nodejs-github-bot
doc,crypto: added sign/verify method changes about dsaEncoding
1f69aa0
PR-URL: #35480
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
danielleadams pushed a commit that referenced this pull request Nov 9, 2020
@panva@danielleadams
doc,crypto: added sign/verify method changes about dsaEncoding
9c4b360
PR-URL: #35480
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@danielleadamsdanielleadams mentioned this pull request Nov 9, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Dec 9, 2020
@panva@BethGriggs
doc,crypto: added sign/verify method changes about dsaEncoding
6e0fe1c
PR-URL: #35480
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
@panva@BethGriggs
doc,crypto: added sign/verify method changes about dsaEncoding
9eeae3b
PR-URL: #35480
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@BethGriggsBethGriggs mentioned this pull request Dec 10, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Dec 15, 2020
@panva@BethGriggs
doc,crypto: added sign/verify method changes about dsaEncoding
4faf71b
PR-URL: #35480
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@panva
panva deleted the dsa-encoding-doc branch October 13, 2022 09:13
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@addaleaxaddaleaxaddaleax approved these changes
@lpincalpincalpinca approved these changes
@tniessentniessentniessen approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.cryptoIssues and PRs related to the crypto subsystem.docIssues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@panva@jasnell@addaleax@lpinca@tniessen@aduh95@nodejs-github-bot