deps: backport 8d6a228 from the v8's upstream by indutny · Pull Request #3549 · nodejs/node

indutny · 2015-10-27T16:57:18Z

Original commit message:

[heap] fix crash during the scavenge of ArrayBuffer
Scavenger should not attempt to visit ArrayBuffer's storage, it is a
user-supplied pointer that may have any alignment. Visiting it, may
result in a crash.
BUG=
R=jochen
Review URL: https://codereview.chromium.org/1406133003
Cr-Commit-Position: refs/heads/master@{#31611}

This is very critical ArrayBuffer fix, and we should backport it to v4 and make a release.

R= @bnoordhuis

cc @nodejs/v8

Original commit message: [heap] fix crash during the scavenge of ArrayBuffer Scavenger should not attempt to visit ArrayBuffer's storage, it is a user-supplied pointer that may have any alignment. Visiting it, may result in a crash. BUG= R=jochen Review URL: https://codereview.chromium.org/1406133003 Cr-Commit-Position: refs/heads/master@{nodejs#31611}

trevnorris · 2015-10-27T17:01:27Z

LGTM. Didn't you already back port this?

indutny · 2015-10-27T17:02:15Z

@trevnorris this is a new one

indutny · 2015-10-27T17:20:35Z

CI: https://ci.nodejs.org/job/node-test-pull-request/629/

Fishrock123 · 2015-10-27T17:29:47Z

Cc @nodejs/lts

jasnell · 2015-10-27T17:35:24Z

Tagged... @Fishrock123 and @indutny , if possible, please use the lts-watch label. I'm working up a tool that'll help triage and cherry pick these kinds of commits in a more automated way and the label definitely helps with that 👍

indutny · 2015-10-27T18:05:36Z

I guess CI is looking good? cc @jasnell

jasnell · 2015-10-27T18:22:40Z

@indutny @Fishrock123 ... I'll be working up a new v4.x release today and tomorrow. How about I look to do a release candidate by tomorrow afternoon? Then cut the actual v4.2.2 release on Thursday or Monday assuming everything looks good with the RC? Or is this a much higher priority than that?

indutny · 2015-10-27T18:24:26Z

Of course! Just be aware that this bug is already causing issues for one company, and they are waiting for the patch to deploy 4.x in their product. (Can't really name the company unless they will decide to comment on this themselves)

jasnell · 2015-10-27T18:31:19Z

Ok, I'll work on getting the final few commits landed into v4.x-staging today and will get the v4.2.2 Request Proposal put together this evening. I'll do a release candidate build tomorrow and we can go from there. If all goes well, we can hopefully get v4.2.2 out by Thursday but if there are any regressions it could slip to Monday because we definitely do not want to do a new LTS release on a Friday.
/cc @mhdawson

indutny · 2015-10-27T18:34:01Z

@jasnell of course. Thank you for this!

jasnell · 2015-10-28T00:02:50Z

@indutny ... looking at cherry picking commits now. I can only pull over commits that have landed so please give me a ping when this one hits in master

indutny · 2015-10-28T00:17:21Z

@jasnell landed in 3223704

Original commit message: [heap] fix crash during the scavenge of ArrayBuffer Scavenger should not attempt to visit ArrayBuffer's storage, it is a user-supplied pointer that may have any alignment. Visiting it, may result in a crash. BUG= R=jochen Review URL: https://codereview.chromium.org/1406133003 Cr-Commit-Position: refs/heads/master@{#31611} PR-URL: #3549 Reviewed-By: Trevor Norris <trev.norris@gmail.com>

jasnell · 2015-10-28T00:38:08Z

Ok, I optimistically attempted to cherry pick it onto v4.x-staging and the commit definitely does not land cleanly. It'll need a bit of fixing up before it can land. @indutny, if you have the time I'd appreciate some help with that.

Original commit message: [heap] fix crash during the scavenge of ArrayBuffer Scavenger should not attempt to visit ArrayBuffer's storage, it is a user-supplied pointer that may have any alignment. Visiting it, may result in a crash. BUG= R=jochen Review URL: https://codereview.chromium.org/1406133003 Cr-Commit-Position: refs/heads/master@{nodejs#31611} PR-URL: nodejs#3549 Reviewed-By: Trevor Norris <trev.norris@gmail.com>

indutny · 2015-10-28T01:51:18Z

@jasnell backported in 58e0127, please give it a try

indutny · 2015-10-28T01:51:44Z

Argh, actually 792ac6d sorry!

Original commit message: [heap] fix crash during the scavenge of ArrayBuffer Scavenger should not attempt to visit ArrayBuffer's storage, it is a user-supplied pointer that may have any alignment. Visiting it, may result in a crash. BUG= R=jochen Review URL: https://codereview.chromium.org/1406133003 Cr-Commit-Position: refs/heads/master@{#31611} PR-URL: #3549 Reviewed-By: Trevor Norris <trev.norris@gmail.com>

jasnell · 2015-10-28T02:49:42Z

Ok, 792ac6d Landed in v4.x-staging as 9061aa2

indutny · 2015-10-28T03:29:27Z

Thank you, James!

Original commit message: [heap] fix crash during the scavenge of ArrayBuffer Scavenger should not attempt to visit ArrayBuffer's storage, it is a user-supplied pointer that may have any alignment. Visiting it, may result in a crash. BUG= R=jochen Review URL: https://codereview.chromium.org/1406133003 Cr-Commit-Position: refs/heads/master@{#31611} PR-URL: #3549 Reviewed-By: Trevor Norris <trev.norris@gmail.com>

rvagg · 2015-10-28T04:06:44Z

I've had a go at backporting to v3.x @ 6a457bd for inclusion in v3.3.2, it seem to be still relevant for V8 4.4.

rvagg · 2015-10-28T04:10:41Z

Without much success, perhaps it's not a problem in V8 4.4 but I'd love confirmation if you have time @indutny:

../deps/v8/src/heap/heap.cc:5046:19: error: no member named 'ContentType' in 'v8::internal::HeapObject'
switch (target->ContentType()) {
~~~~~~ ^
1 error generated.

indutny · 2015-10-28T05:12:54Z

@rvagg is it from 3.3.2?

indutny · 2015-10-28T05:15:13Z

@rvagg this patch should not be backported to it.

rvagg · 2015-10-28T05:26:13Z

thanks, backing it out and pushing 3.3.2 forward

indutny · 2015-10-28T05:29:33Z

@rvagg I will look into it deeply tomorrow to see if there should be any kind of other fix for 3.3.2

bnoordhuis · 2015-10-28T11:15:47Z

Belated LGTM.

Original commit message: [heap] fix crash during the scavenge of ArrayBuffer Scavenger should not attempt to visit ArrayBuffer's storage, it is a user-supplied pointer that may have any alignment. Visiting it, may result in a crash. BUG= R=jochen Review URL: https://codereview.chromium.org/1406133003 Cr-Commit-Position: refs/heads/master@{nodejs#31611} PR-URL: nodejs#3549 Reviewed-By: Trevor Norris <trev.norris@gmail.com>

Original commit message: [heap] fix crash during the scavenge of ArrayBuffer Scavenger should not attempt to visit ArrayBuffer's storage, it is a user-supplied pointer that may have any alignment. Visiting it, may result in a crash. BUG= R=jochen Review URL: https://codereview.chromium.org/1406133003 Cr-Commit-Position: refs/heads/master@{#31611} PR-URL: #3549 Reviewed-By: Trevor Norris <trev.norris@gmail.com>

Original commit message: [heap] fix crash during the scavenge of ArrayBuffer Scavenger should not attempt to visit ArrayBuffer's storage, it is a user-supplied pointer that may have any alignment. Visiting it, may result in a crash. BUG= R=jochen Review URL: https://codereview.chromium.org/1406133003 Cr-Commit-Position: refs/heads/master@{nodejs#31611} PR-URL: nodejs#3549 Reviewed-By: Trevor Norris <trev.norris@gmail.com>

indutny added v8 engine Issues and PRs related to the V8 dependency. land-on-v4.x labels Oct 27, 2015

indutny assigned bnoordhuis Oct 27, 2015

jasnell added the lts-watch-v4.x label Oct 27, 2015

rvagg mentioned this pull request Oct 27, 2015
Release proposal: v3.3.2 (final io.js v3.x) #3465
Closed

indutny closed this Oct 28, 2015

indutny deleted the fix/v8-1406133003 branch October 28, 2015 00:17

jasnell removed the lts-watch-v4.x label Oct 28, 2015

rvagg mentioned this pull request Oct 28, 2015
Preparing v4.2.2 LTS Maintenance nodejs/Release#50
Closed

rvagg mentioned this pull request Oct 29, 2015
Release proposal: v5.0.0 #3466
Merged

jasnell mentioned this pull request Oct 29, 2015
Release Proposal: v4.2.2 "Argon" (LTS) #3588
Closed

jasnell removed the land-on-v4.x label Nov 3, 2015

targos added the v8-backport-to-4.7 label Nov 18, 2015

indutny mentioned this pull request Dec 12, 2015
deps: backport 8d6a228 from the v8's upstream #4259
Closed

Uh oh!

Uh oh!

Conversation

indutny commented Oct 27, 2015

Uh oh!

trevnorris commented Oct 27, 2015

Uh oh!

indutny commented Oct 27, 2015

Uh oh!

indutny commented Oct 27, 2015

Uh oh!

Fishrock123 commented Oct 27, 2015

Uh oh!

jasnell commented Oct 27, 2015

Uh oh!

indutny commented Oct 27, 2015

Uh oh!

jasnell commented Oct 27, 2015

Uh oh!

indutny commented Oct 27, 2015

Uh oh!

jasnell commented Oct 27, 2015

Uh oh!

indutny commented Oct 27, 2015

Uh oh!

jasnell commented Oct 28, 2015

Uh oh!

indutny commented Oct 28, 2015

Uh oh!

jasnell commented Oct 28, 2015

Uh oh!

indutny commented Oct 28, 2015

Uh oh!

indutny commented Oct 28, 2015

Uh oh!

jasnell commented Oct 28, 2015

Uh oh!

indutny commented Oct 28, 2015

Uh oh!

rvagg commented Oct 28, 2015

Uh oh!

rvagg commented Oct 28, 2015

Uh oh!

indutny commented Oct 28, 2015

Uh oh!

indutny commented Oct 28, 2015

Uh oh!

rvagg commented Oct 28, 2015

Uh oh!

indutny commented Oct 28, 2015

Uh oh!

bnoordhuis commented Oct 28, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants