Uh oh!
There was an error while loading. Please reload this page.
Closed
Conversation
- change http client path assignment from to (it's more appropriate in this case). - since the inner condition is the only referencing the variable, moved the assignment to the inner condition.
ghost
self-requested a review
as a code ownerOctober 5, 2020 20:57
nodejs-github-bot
commented
Oct 5, 2020
Collaborator
Review requested:
|
Trott
approved these changes
Oct 6, 2020
This comment has been minimized.
This comment has been minimized.
morpalgi
approved these changes
Oct 6, 2020
ghost
commented
Oct 8, 2020
Author
@Trott some of the tests are failing due to a timeout, can we run the failed tests again? |
Flarna
approved these changes
Oct 8, 2020
This comment has been minimized.
This comment has been minimized.
rickyes
approved these changes
Oct 8, 2020
nodejs-github-bot
commented
Oct 8, 2020
Collaborator
Contributor
Landed in f512ce6 |
nodejs-github-bot pushed a commit
that referenced
this pull request
Oct 8, 2020
- change http client path assignment from to (it's more appropriate in this case). - since the inner condition is the only referencing the variable, moved the assignment to the inner condition. PR-URL: #35508 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
ghost
deleted the
fix/http-agent-path
branch
October 9, 2020 11:29
BethGriggs pushed a commit
that referenced
this pull request
Oct 13, 2020
- change http client path assignment from to (it's more appropriate in this case). - since the inner condition is the only referencing the variable, moved the assignment to the inner condition. PR-URL: #35508 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Merged
MylesBorins pushed a commit
that referenced
this pull request
Nov 3, 2020
- change http client path assignment from to (it's more appropriate in this case). - since the inner condition is the only referencing the variable, moved the assignment to the inner condition. PR-URL: #35508 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Merged
MylesBorins pushed a commit
that referenced
this pull request
Nov 16, 2020
- change http client path assignment from to (it's more appropriate in this case). - since the inner condition is the only referencing the variable, moved the assignment to the inner condition. PR-URL: #35508 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
joesepi pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
- change http client path assignment from to (it's more appropriate in this case). - since the inner condition is the only referencing the variable, moved the assignment to the inner condition. PR-URL: nodejs#35508 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changed path assignment in http client lib from
lettoconst(it's more appropriate in this case).I addition to that, since the inner condition is the only referencing the variable, moved the assignment to the inner condition
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes