Skip to content

doc: use sentence case for class property - #35540

Merged
Trott merged 1 commit into
nodejs:masterfrom
Trott:class-prop-case
Oct 9, 2020
Merged

doc: use sentence case for class property#35540
Trott merged 1 commit into
nodejs:masterfrom
Trott:class-prop-case

Conversation

@Trott

@TrottTrott commented Oct 7, 2020

Copy link
Copy Markdown
Member

Change the one instance of the Class Property heading in our docs to
Class property to match style with other headers.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory. labels Oct 7, 2020
@Trott

Trott commented Oct 7, 2020

Copy link
Copy Markdown
MemberAuthor

Before:

image

After:

image

@TrottTrott added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 7, 2020
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 7, 2020
@nodejs-github-bot

nodejs-github-bot commented Oct 7, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33452/

@Trott
doc: use sentence case for class property
936ce85
Change the one instance of the Class Property heading in our docs to
Class property to match style with other headers.
PR-URL: nodejs#35540
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@Trott
Trott merged commit 936ce85 into nodejs:masterOct 9, 2020
@Trott

Trott commented Oct 9, 2020

Copy link
Copy Markdown
MemberAuthor

Landed in 936ce85

@Trott
Trott deleted the class-prop-case branch October 9, 2020 13:11
BethGriggs pushed a commit that referenced this pull request Oct 14, 2020
@Trott@BethGriggs
doc: use sentence case for class property
85dc84d
Change the one instance of the Class Property heading in our docs to
Class property to match style with other headers.
PR-URL: #35540
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@MylesBorinsMylesBorins mentioned this pull request Oct 14, 2020
Merged
MylesBorins pushed a commit that referenced this pull request Nov 3, 2020
@Trott@MylesBorins
doc: use sentence case for class property
b3c0f66
Change the one instance of the Class Property heading in our docs to
Class property to match style with other headers.
PR-URL: #35540
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@MylesBorinsMylesBorins mentioned this pull request Nov 3, 2020
Merged
MylesBorins pushed a commit that referenced this pull request Nov 16, 2020
@Trott@MylesBorins
doc: use sentence case for class property
42c4795
Change the one instance of the Class Property heading in our docs to
Class property to match style with other headers.
PR-URL: #35540
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
@Trott@joesepi
doc: use sentence case for class property
3d7ee18
Change the one instance of the Class Property heading in our docs to
Class property to match style with other headers.
PR-URL: nodejs#35540
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleaxaddaleaxaddaleax approved these changes
@lpincalpincalpinca approved these changes

Assignees

No one assigned

Labels

docIssues and PRs related to the documentations.toolsIssues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Trott@nodejs-github-bot@addaleax@lpinca