Uh oh!
There was an error while loading. Please reload this page.
doc: add documentation for starting ci job via label - #35551
Closed
juanarbol wants to merge 1 commit into
Closed
Conversation
nodejs-github-bot
commented
Oct 7, 2020
Collaborator
Review requested:
|
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
gengjiawen
approved these changes
Oct 8, 2020
Trott
reviewed
Oct 8, 2020
Uh oh!
There was an error while loading. Please reload this page.
Trott
approved these changes
Oct 8, 2020
codebytere
approved these changes
Oct 8, 2020
Flarna
approved these changes
Oct 8, 2020
Flarna
left a comment
Member
There was a problem hiding this comment.
Maybe add that request-ci label is removed automatically once the CI job has been started.
antsmartian
approved these changes
Oct 10, 2020
juanarbolforce-pushed
the
juanarbol/add-kickoff-ci-doc
branch
from
October 13, 2020 23:22
1a24062 to
5cfe307Comparejuanarbol added a commit
to juanarbol/node
that referenced
this pull request
Oct 13, 2020
PR-URL: nodejs#35551 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
juanarbol
commented
Oct 13, 2020
MemberAuthor
Landed in d5e6495 |
MylesBorins pushed a commit
that referenced
this pull request
Oct 14, 2020
PR-URL: #35551 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Merged
joesepi pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
PR-URL: nodejs#35551 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
This was referenced Sep 29, 2022
This was referenced Oct 5, 2022
This was referenced Oct 8, 2022
This was referenced Oct 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Special thanks to @mmarchini, this is a really awesome feature!!
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes