Uh oh!
There was an error while loading. Please reload this page.
doc: remove "Synchronously" for fsPromises.rm() - #35568
Closed
Trott wants to merge 1 commit into
Closed
Conversation
Because it's a promise, fsPromises.rm() is asynchronous. That is implicit in every other fsPromises entry, so this removes "Synchronously" rather than replacing it with "Asynchronously".
Contributor
FYI there is already an open PR with this change: #35561. |
bcoe
commented
Oct 9, 2020
Contributor
Trott
commented
Oct 11, 2020
MemberAuthor
Addressed by 71a48c3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because it's a promise, fsPromises.rm() is asynchronous. That is
implicit in every other fsPromises entry, so this removes
"Synchronously" rather than replacing it with "Asynchronously".
@iansu@bcoe
Checklist