Uh oh!
There was an error while loading. Please reload this page.
doc: document rmdir/recursive deprecation - #35579
Closed
bcoe wants to merge 5 commits into
Closed
Conversation
Document deprecation of rmdir/recursive permissive functionality
addaleax
reviewed
Oct 9, 2020
Uh oh!
There was an error while loading. Please reload this page.
Trott
reviewed
Oct 9, 2020
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Anna Henningsen <github@addaleax.net>
Trott
approved these changes
Oct 10, 2020
This comment has been minimized.
This comment has been minimized.
aduh95
approved these changes
Oct 10, 2020
targos
approved these changes
Oct 10, 2020
iansu
approved these changes
Oct 10, 2020
nodejs-github-bot
commented
Oct 11, 2020
Collaborator
Trott
approved these changes
Oct 12, 2020
bcoe
commented
Oct 12, 2020
ContributorAuthor
Landed in c759281 |
4 tasks
Merged
joesepi pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
Document deprecation of rmdir/recursive permissive functionality PR-URL: nodejs#35579 Refs: nodejs#35562 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Document deprecation of rmdir/recursive permissive functionality.
As suggested by @aduh95, this adds the deprecation of the permissive behavior of
rmdir/recursiveas a docs only deprecation, in thedeprecations.md.We already updated the docs in #35171, to mention that the permissive behavior will one day be removed.
Refs: #35562
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesCC: @iansu