Uh oh!
There was an error while loading. Please reload this page.
module: cjs-module-lexer@0.4.2 big endian fix - #35634
Closed
guybedford wants to merge 2 commits into
Closed
Conversation
nodejs-github-bot
commented
Oct 13, 2020
Collaborator
Review requested:
|
nodejs-github-bot
commented
Oct 13, 2020
Collaborator
richardlau
approved these changes
Oct 13, 2020
richardlau
left a comment
Member
There was a problem hiding this comment.
LGTM with a passing CI. Wasn't there a documentation link that should be updated to match the version of cjs-module-lexer used?
guybedford
commented
Oct 13, 2020
ContributorAuthor
@richardlau thanks, well-remembered! |
nodejs-github-bot
commented
Oct 13, 2020
Collaborator
nodejs-github-bot
commented
Oct 13, 2020
Collaborator
targos
approved these changes
Oct 14, 2020
Contributor
I think it might be a good idea to also get nodejs/cjs-module-lexer#14 into this. Also, there’s a major bug in big endian mode that causes the most significant nibble to be discarded: nodejs/cjs-module-lexer#13 (comment). |
nodejs-github-bot
commented
Oct 14, 2020
Collaborator
guybedford
commented
Oct 14, 2020
ContributorAuthor
@ExE-Boss thanks for spotting that, it wasn't affecting the execution because the mask was unnecessary due to the bit shift. I've updated to 0.4.2 that corrects the unnecessary op. |
MylesBorins
commented
Oct 14, 2020
Contributor
@guybedford is this ready to go? |
guybedford
commented
Oct 14, 2020
ContributorAuthor
@MylesBorins yes it is, it just needs another 24 hours to land I think unless you want to fast track. |
MylesBorins
commented
Oct 14, 2020
Contributor
can we fast-track? |
MylesBorins pushed a commit
that referenced
this pull request
Oct 14, 2020
PR-URL: #35634 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
MylesBorins
commented
Oct 14, 2020
Contributor
Landed in ab0af50 |
MylesBorins pushed a commit
that referenced
this pull request
Oct 14, 2020
PR-URL: #35634 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Merged
MylesBorins pushed a commit
that referenced
this pull request
Nov 3, 2020
PR-URL: #35634 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Merged
MylesBorins pushed a commit
that referenced
this pull request
Nov 16, 2020
PR-URL: #35634 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
joesepi pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
PR-URL: nodejs#35634 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates to cjs-module-lexer@0.4.1 with the fix at nodejs/cjs-module-lexer#13 for big endian support.
This should fix the previous Web Assembly issues found in #35583.
Note this is a performance improvement only and not a bug fix since we had the gracefull fallback previously.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes