Uh oh!
There was an error while loading. Please reload this page.
src,crypto: remove redundant OpenSSLBuffer - #35663
Closed
jasnell wants to merge 1 commit into
Closed
Conversation
nodejs-github-bot
commented
Oct 15, 2020
Collaborator
Review requested:
|
Replace the OpenSSLBuffer utility with ByteSource and remove OpenSSLBuffer. Signed-off-by: James M Snell <jasnell@gmail.com>
jasnellforce-pushed
the
crypto-remove-opensslbuffer
branch
from
October 15, 2020 18:45
10f08e4 to
2cda44aCompare
This comment has been minimized.
This comment has been minimized.
nodejs-github-bot
commented
Oct 16, 2020
Collaborator
Collaborator
tniessen
approved these changes
Oct 24, 2020
Trott
approved these changes
Oct 31, 2020
fhinkel
approved these changes
Nov 2, 2020
jasnell added a commit
that referenced
this pull request
Nov 4, 2020
Replace the OpenSSLBuffer utility with ByteSource and remove OpenSSLBuffer. Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #35663 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
jasnell
commented
Nov 4, 2020
MemberAuthor
Landed in fc8e3e2 |
targos pushed a commit
that referenced
this pull request
Nov 4, 2020
Replace the OpenSSLBuffer utility with ByteSource and remove OpenSSLBuffer. Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #35663 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the OpenSSLBuffer utility with ByteSource and remove OpenSSLBuffer.
Signed-off-by: James M Snell jasnell@gmail.com
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes