src,crypto: refactoring of crypto_context, SecureContext by jasnell · Pull Request #35665 · nodejs/node

- Loading data for nodejs/node/pull/35665
✔ Done loading data for nodejs/node/pull/35665
----------------------------------- PR info ------------------------------------
Title src,crypto: refactoring of crypto_context, SecureContext (#35665)
Author James M Snell (@jasnell)
Branch jasnell:crypto-cleanup-securecontext -> nodejs:master
Labels C++, author ready, crypto, errors, tls
Commits 1
- src,crypto: refactoring of crypto_context, SecureContext
Committers 1
- James M Snell PR-URL: https://github.com/nodejs/node/pull/35665
Reviewed-By: Alba Mendez Reviewed-By: Tobias Nießen Reviewed-By: Rich Trott Reviewed-By: Franziska Hinkelmann ------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/35665
Reviewed-By: Alba Mendez Reviewed-By: Tobias Nießen Reviewed-By: Rich Trott Reviewed-By: Franziska Hinkelmann --------------------------------------------------------------------------------
⚠ Commits were pushed since the last review:
⚠ - src,crypto: refactoring of crypto_context, SecureContext
✔ Last GitHub Actions successful
ℹ Last Full PR CI on 2020-11-10T09:45:35Z: https://ci.nodejs.org/job/node-test-pull-request/34275/
- Querying data for job/node-test-pull-request/34275/
✔ Build data downloaded
✔ Last Jenkins CI successful
ℹ This PR was created on Thu, 15 Oct 2020 23:54:44 GMT
✔ Approvals: 4
✔ - Alba Mendez (@mildsunrise): https://github.com/nodejs/node/pull/35665#pullrequestreview-510987295
✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/35665#pullrequestreview-511000285
✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/35665#pullrequestreview-511141489
✔ - Franziska Hinkelmann (@fhinkel) (TSC): https://github.com/nodejs/node/pull/35665#pullrequestreview-511619185
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu

Commit Queue action: https://github.com/nodejs/node/actions/runs/356556511

Cleaup and improvement of crypto_context and SecureContext. Signed-off-by: James M Snell <jasnell@gmail.com>

Cleaup and improvement of crypto_context and SecureContext. Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #35665 Reviewed-By: Alba Mendez <me@alba.sh> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>

jasnell · 2020-11-11T20:06:04Z

Landed in 35274cb

Cleaup and improvement of crypto_context and SecureContext. Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #35665 Reviewed-By: Alba Mendez <me@alba.sh> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>

benjamingr · 2021-05-19T10:42:01Z

Hey, this broke socket.io which passes null as the pfx value - it has been fixed since but worth mentioning.

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. tls Issues and PRs related to the tls subsystem. labels Oct 15, 2020

jasnell added crypto Issues and PRs related to the crypto subsystem. errors Issues and PRs related to JavaScript errors originated in Node.js core. request-ci Add this label to start a Jenkins CI on a PR. labels Oct 15, 2020

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 16, 2020

jasnell added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 16, 2020

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 16, 2020

This comment has been minimized.
Sign in to view

mildsunrise approved these changes Oct 17, 2020
View reviewed changes

Comment threadlib/_tls_common.js Outdated
Comment threadlib/_tls_common.js Outdated

tniessen approved these changes Oct 17, 2020
View reviewed changes

Trott reviewed Oct 18, 2020
View reviewed changes

Comment threadlib/_tls_common.js Outdated

Trott reviewed Oct 18, 2020
View reviewed changes

Comment threadsrc/crypto/crypto_context.cc Outdated

This comment has been minimized.
Sign in to view

Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 18, 2020

Trott approved these changes Oct 18, 2020
View reviewed changes

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 18, 2020

fhinkel approved these changes Oct 19, 2020
View reviewed changes

jasnell force-pushed the crypto-cleanup-securecontext branch from 30ac425 to 1f8120cCompare November 4, 2020 00:15

jasnell added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 4, 2020

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 4, 2020

This comment has been minimized.
Sign in to view

jasnell force-pushed the crypto-cleanup-securecontext branch from 1f8120c to 33e7a62Compare November 6, 2020 22:04

jasnell added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 6, 2020

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 6, 2020

This comment has been minimized.
Sign in to view

jasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 6, 2020

This comment has been minimized.
Sign in to view

aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 10, 2020

github-actionsBot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 10, 2020

github-actionsBot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Nov 10, 2020

aduh95 reviewed Nov 10, 2020
View reviewed changes

Comment threadlib/_tls_common.js Outdated
Comment threadlib/_tls_common.js Outdated
Comment threadlib/_tls_common.js Outdated
Comment threadlib/_tls_common.js Outdated

aduh95 removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Nov 10, 2020

src,crypto: refactoring of crypto_context, SecureContext
99dde03
Cleaup and improvement of crypto_context and SecureContext. Signed-off-by: James M Snell <jasnell@gmail.com>

jasnell force-pushed the crypto-cleanup-securecontext branch from 33e7a62 to 99dde03Compare November 11, 2020 20:01

aduh95 approved these changes Nov 11, 2020
View reviewed changes

jasnell closed this Nov 11, 2020

codebytere mentioned this pull request Nov 22, 2020
v15.3.0 proposal #36232
Merged

targos added the dont-land-on-v14.x label May 16, 2021

Uh oh!

Uh oh!

Conversation

jasnell commented Oct 15, 2020

Checklist

Uh oh!

nodejs-github-bot commented Oct 15, 2020

Uh oh!

nodejs-github-bot commented Oct 16, 2020

Uh oh!

This comment has been minimized.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

nodejs-github-bot commented Oct 18, 2020

Uh oh!

nodejs-github-bot commented Oct 19, 2020

Uh oh!

This comment has been minimized.

nodejs-github-bot commented Nov 6, 2020

Uh oh!

This comment has been minimized.

This comment has been minimized.

nodejs-github-bot commented Nov 10, 2020

Uh oh!

github-actionsBot commented Nov 10, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jasnell commented Nov 11, 2020

Uh oh!

benjamingr commented May 19, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants