Uh oh!
There was an error while loading. Please reload this page.
tools: bump remark-lint-preset-node to 1.17.1 - #35668
Merged
Merged
Conversation
bcoe
approved these changes
Oct 16, 2020
bcoe
left a comment
Contributor
There was a problem hiding this comment.
Was the order of deprecation comments one of the things it lints?
This will make the deprecation process much easier 👍
Trott
commented
Oct 16, 2020
MemberAuthor
Yes. This includes nodejs/remark-preset-lint-node#139 by @aduh95. |
aduh95
approved these changes
Oct 16, 2020
Trott
commented
Oct 18, 2020
MemberAuthor
Landed in ee85eb9...fbe33aa |
Trott added a commit
to Trott/io.js
that referenced
this pull request
Oct 18, 2020
This is in preparation for updating remark-preset-lint-node to 1.17.1. PR-URL: nodejs#35668 Reviewed-By: Ben Coe <bencoe@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos pushed a commit
that referenced
this pull request
May 1, 2021
Bump remark-lint-preset-node@1.16.0 to remark-lint-preset-node@1.17.1. Refs: nodejs/remark-preset-lint-node#139 PR-URL: #35668 Reviewed-By: Ben Coe <bencoe@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Merged
danielleadams pushed a commit
that referenced
this pull request
May 8, 2021
Bump remark-lint-preset-node@1.16.0 to remark-lint-preset-node@1.17.1. Refs: nodejs/remark-preset-lint-node#139 PR-URL: #35668 Reviewed-By: Ben Coe <bencoe@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First commit:
Second commit:
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes