Uh oh!
There was an error while loading. Please reload this page.
test: add additional deprecation warning tests for rmdir recursive - #35683
Closed
iansu wants to merge 2 commits into
Closed
test: add additional deprecation warning tests for rmdir recursive#35683iansu wants to merge 2 commits into
iansu wants to merge 2 commits into
Conversation
iansuforce-pushed
the
more-rmdir-recursive-tests
branch
from
October 16, 2020 18:11
1c6e32d to
4ea6e4aComparebcoe
reviewed
Oct 17, 2020
bcoe
left a comment
Contributor
There was a problem hiding this comment.
This is looking good to me, it would be good to run your new tests with coverage.
I will add a section to the docs on how to do so.
| tmpdir.refresh(); | ||
Contributor
There was a problem hiding this comment.
nit: we usually try to avoid unrelated whitespace changes.
ContributorAuthor
There was a problem hiding this comment.
Good to know. I'm pretty sure I accidentally added this extra whitespace in my previous PR so I was just cleaning it up.
Trott
approved these changes
Oct 17, 2020
This comment has been minimized.
This comment has been minimized.
nodejs-github-bot
commented
Oct 17, 2020
Collaborator
aduh95
reviewed
Oct 19, 2020
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
codecov-io
commented
Oct 19, 2020
Codecov Report
@@ Coverage Diff @@## master #35683 +/- ##
=======================================
Coverage 96.40% 96.40% =======================================
Files 220 220 Lines 73681 73675 -6 =======================================
- Hits 71031 71028 -3 + Misses 2650 2647 -3
Continue to review full report at Codecov.
|
bcoe
approved these changes
Oct 20, 2020
nodejs-github-bot
commented
Oct 20, 2020
Collaborator
nodejs-github-bot
commented
Oct 21, 2020
Collaborator
bcoe
commented
Oct 21, 2020
Contributor
aduh95
approved these changes
Oct 21, 2020
aduh95 pushed a commit
that referenced
this pull request
Oct 24, 2020
PR-URL: #35683 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ben Coe <bencoe@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95
commented
Oct 24, 2020
Contributor
Landed in c5b9b5b |
targos pushed a commit
that referenced
this pull request
Nov 3, 2020
PR-URL: #35683 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ben Coe <bencoe@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The recently added code coverage in #35653 highlighted an uncovered case of the rmdir recursive deprecation warning. This PR adds two new tests to ensure we cover all the places where the deprecation warning can be shown in both the sync and async versions.
cc @bcoe @nodejs/tooling
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes